Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor requests #13

Closed
wants to merge 7 commits into from
Closed

Refactor requests #13

wants to merge 7 commits into from

Conversation

im-voracity
Copy link
Owner

0.5.0 / 2024-03-24

  • Changed underlying way of making requests, now standardizing the output of the response for it
    to be always a list of dicts.
  • Added new _handle_response method for standardizing the response.
  • Added new decorator @paginate for handling pagination in the endpoints.
  • Removed old _paginate method.
  • Changed references to the old _paginate method to _request_with_token.
  • Enhanced type hints for better readability.
  • Most tests were refactored to reflect the changes in the new request handling.
  • Fixed a bug where subscriber_code was not being passed to the request body as expected in
    change_due_day method.
  • Updated README with the new changes.

@im-voracity
- Better error handling for _make_request.
ae157e9 
- Removed custom exceptions.

- Changed tests to better fit exceptions changes.
@im-voracity
Fixed typo in _make_request log
ced8546
@im-voracity
Changed base URL building method for better support of new endpoints …
b4a2beb 
…in the future. Also refactored some tests.
@im-voracity
Fixed bug where _make_request response variable could not be defined …
0ef26e9 
…in case of exceptions.

Changed tests for _make_request and test_sandbox
@im-voracity
Changed all the underlying way of making requests.
1a4785a 
Specially how pagination works.

Refactored all tests to better reflect what each method need testing.
@im-voracity
Fixed bug where @paginate decorator was not paginating.
a45356c 
All methods now support enhancement.

Test adjusted to support enhance.
@im-voracity
Updated docs for better reflecting changes.
f4e1545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@im-voracity