custom border radius in BarTouchTooltipData #1754
Conversation
| @@ -702,6 +705,7 @@ class BarTouchTooltipData with EquatableMixin { | |||
| /// also you can set [fitInsideVertically] true to force it to shift inside the chart vertically. | |||
| BarTouchTooltipData({ | |||
| double? tooltipRoundedRadius, | |||
| BorderRadius? tooltipBorderRadius, | |||
There was a problem hiding this comment.
We already have the tooltipRoundedRadius property. If you want to add it, please remove the old one.
There was a problem hiding this comment.
Yes, that’s true, but with the current parameter, all the borders must be the same. I didn’t want to remove the existing one to avoid causing a breaking change.
There was a problem hiding this comment.
You're right, we should keep it backward-compatible.
So can you please make the old one tooltipRoundedRadius deprecated? This way we can remove it in the next releases
CHANGELOG.md
Outdated
| @@ -1,3 +1,6 @@ | |||
| ## UNRELEASED | |||
| * **IMPROVEMENT** (by @MattiaPispisa) custom border radius in BarTouchTooltipData, #1715 | |||
There was a problem hiding this comment.
You don't need to write a changelog here, please read our contributing guideline
There was a problem hiding this comment.
I had read the guidelines, and it was recommended to start from an issue. From the ‘Mention the related issues’ section, what I did seemed correct. What should I have done differently?
Thank you.
There was a problem hiding this comment.
Ahh, you're right. I'm sorry I forgot to update one part of the guideline.
I just updated it here.
As we had a lot of conflicts in the change log part, I decided to update it by myself. So you don't need to write something.
Maybe, it would be a good idea to just copy-paste yours in the PR's description. This way I can just add it.
|
Hi @imaNNeo, no problem. I removed the changelog and included what I had written in the issue description. |
|
Very nice! Also please rebase your branch. |
MattiaPispisa
force-pushed
the
feature/bar_tooltip_radius
branch
from
a8bee94 to
32cfb79
Compare
|
Thank you! I've applied the same changes to both I also made a rebased with |
IMPROVEMENT (by @MattiaPispisa) custom border radius in
BarTouchTooltipData,LineTouchTooltipData,ScatterTouchTooltipData#1715