Make the parametric type of CachedMapper to be the return type #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikcfd
force-pushed
the
correct_cached_mapper_types
branch
from
2a16e44 to
b4de0ab
Compare
inducer
force-pushed
the
correct_cached_mapper_types
branch
from
b4de0ab to
c74acdf
Compare
inducer
reviewed
Apr 19, 2023
kaushikcfd
force-pushed
the
correct_cached_mapper_types
branch
from
c74acdf to
cc756f2
Compare
inducer
force-pushed
the
correct_cached_mapper_types
branch
from
cc756f2 to
1cde5f3
Compare
|
Thx! Pushed a minor fix, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, the parametric type in CachedMapper denoted the input type of the mapper which is unnecessary as the input type is always
ArrayOrNames.I think #409 is also talking about this same thing.