Disambiguate const array literals from parenthesized primary expressions #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgardn3r
requested changes
Sep 9, 2024
delphi-checks/src/test/java/au/com/integradev/delphi/checks/RedundantParenthesesCheckTest.java
Show resolved
Hide resolved
Cirras
force-pushed
the
const_array_literals
branch
from
a9a2936 to
fa1c58e
Compare
Some of our `constExpression` usages were in places that couldn't actually have an array or record literal.
Cirras
force-pushed
the
const_array_literals
branch
from
fa1c58e to
f3fd2b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a parsing bug where const array literal expressions would be confused with parenthesized primary expressions.
The official parser builds type information incrementally during parsing and relies on it to know what may appear on the right side of an assignment (which is another point in favor of #261).
With our current approach to parsing, the fix for this problem is a slightly gnarly repetition of rules in the ANTLR3 grammar.