Implemented Roberta Model #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@juliagsy I am ready for review |
juliagsy
suggested changes
Aug 7, 2023
|
@juliagsy I have implemented the required changes and completed the testing |
juliagsy
suggested changes
Aug 10, 2023
| use_cache=None, | ||
| output_attentions=None, | ||
| ): | ||
| if input_ids[:, 0].sum().item() != 0: |
There was a problem hiding this comment.
should be to_scalar instead of item
| import pytest | ||
| import numpy as np | ||
| from ivy_models import roberta_base | ||
|
|
There was a problem hiding this comment.
could you please quickly ref test_alexnet and make the model object init happen once only for saving ci resources, thanks!
| if load_weights: | ||
| ref_logits_path = os.path.join(this_dir, "roberta_pooled_output.npy") | ||
| ref_logits = np.load(ref_logits_path) | ||
| assert np.allclose(ref_logits, ivy.to_numpy(logits), rtol=0.005, atol=0.005) |
There was a problem hiding this comment.
the value tests are unfortunately not passing when I checked, could you please verify this again?
also, could you please do me a favour and update the load_transformers_weights helper to not use copy.deepcopy and do old_mapping = model.v directly? it's somewhere line 174 in the weights_helpers.py file, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.