Skip to content

Commit

Permalink
remove kubernetes-common dependancy from ocm-bacckend
Browse files Browse the repository at this point in the history
  • Loading branch information
karthikjeeyar committed Oct 18, 2024
1 parent 799f194 commit 2492cb9
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 11 deletions.
5 changes: 2 additions & 3 deletions plugins/ocm-backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
"scripts": {
"build": "backstage-cli package build",
"clean": "backstage-cli package clean",
"export-dynamic": "janus-cli package export-dynamic-plugin --no-embed-as-dependencies",
"export-dynamic:clean": "janus-cli package export-dynamic-plugin --no-embed-as-dependencies --clean",
"export-dynamic": "janus-cli package export-dynamic-plugin",
"export-dynamic:clean": "janus-cli package export-dynamic-plugin --clean",
"lint:check": "backstage-cli package lint",
"lint:fix": "backstage-cli package lint --fix",
"postpack": "backstage-cli package postpack",
Expand All @@ -54,7 +54,6 @@
"@backstage/catalog-model": "^1.7.0",
"@backstage/errors": "^1.2.4",
"@backstage/plugin-catalog-node": "^1.13.0",
"@backstage/plugin-kubernetes-common": "^0.8.3",
"@backstage/plugin-permission-common": "^0.8.1",
"@backstage/plugin-permission-node": "^0.8.3",
"@janus-idp/backstage-plugin-ocm-common": "3.4.1",
Expand Down
1 change: 1 addition & 0 deletions plugins/ocm-backend/src/constants.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
export const CONSOLE_CLAIM = 'consoleurl.cluster.open-cluster-management.io';
export const HUB_CLUSTER_NAME_IN_OCM = 'local-cluster';
export const ANNOTATION_KUBERNETES_API_SERVER = 'kubernetes.io/api-server';
7 changes: 5 additions & 2 deletions plugins/ocm-backend/src/providers/ManagedClusterProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import type {
EntityProvider,
EntityProviderConnection,
} from '@backstage/plugin-catalog-node';
import { ANNOTATION_KUBERNETES_API_SERVER } from '@backstage/plugin-kubernetes-common';

import { CustomObjectsApi } from '@kubernetes/client-node';

Expand All @@ -39,7 +38,11 @@ import {
ANNOTATION_PROVIDER_ID,
} from '@janus-idp/backstage-plugin-ocm-common';

import { CONSOLE_CLAIM, HUB_CLUSTER_NAME_IN_OCM } from '../constants';
import {
ANNOTATION_KUBERNETES_API_SERVER,
CONSOLE_CLAIM,
HUB_CLUSTER_NAME_IN_OCM,
} from '../constants';
import { readOcmConfigs } from '../helpers/config';
import {
getManagedCluster,
Expand Down
14 changes: 8 additions & 6 deletions yarn.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2492cb9

Please sign in to comment.