feat(bulk-import): add permission checks in bulk import UI #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debsmita1
force-pushed
the
bulk-import-rbac
branch
2 times, most recently
from
3d53d38 to
4e776cd
Compare
debsmita1
force-pushed
the
bulk-import-rbac
branch
from
4e776cd to
6984a61
Compare
ciiay
reviewed
Aug 14, 2024
There was a problem hiding this comment.
Hi @debsmita1 , thanks for the PR 👏 Looks like bottom button margin is a bit off.
- If it's admin or user with permission, it should display the
Editicon button instead of theExternal Linkicon button on the Added repositories row. - No loading indicator on deleting a row from Added repositories. Maybe we can improve this behavior? Didn't notice this problem until actually tested out.
pr_bulk_import_permission.mp4
debsmita1
force-pushed
the
bulk-import-rbac
branch
from
6984a61 to
74cdfd0
Compare
Fixed
Still working on this
Showing this spinner before the Button
|
|
Hi @debsmita1 the button margin and delete spinner work great. Not sure if it's in scope of this PR, but when I added a repository, it didn't show up in the Added repositories table. bulk_import_pr_review.mp4 |
debsmita1
force-pushed
the
bulk-import-rbac
branch
2 times, most recently
from
729b486 to
0965c16
Compare
debsmita1
force-pushed
the
bulk-import-rbac
branch
from
0965c16 to
6722529
Compare
debsmita1
force-pushed
the
bulk-import-rbac
branch
from
6722529 to
d511984
Compare
|
Hi @debsmita1 , can you take a look at the Edit action? Icon flashes between edit icon and external link icon. bulk_import_rbac_review.mp4 |
debsmita1
requested review from
christoph-jerolimov and
invincibleJai
and removed request for
PatAKnight and
AndrienkoAleksandr
debsmita1
force-pushed
the
bulk-import-rbac
branch
from
47a6bc7 to
42ac22d
Compare
debsmita1
force-pushed
the
bulk-import-rbac
branch
from
42ac22d to
c3b2891
Compare
debsmita1
force-pushed
the
bulk-import-rbac
branch
5 times, most recently
from
e0f311b to
0e07237
Compare
debsmita1
force-pushed
the
bulk-import-rbac
branch
from
0e07237 to
e288686
Compare
ciiay
approved these changes
Aug 28, 2024
debsmita1
force-pushed
the
bulk-import-rbac
branch
from
e288686 to
e6000fb
Compare
Fixed |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
https://issues.redhat.com/browse/RHIDP-1400