Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(orchestrator): provide API for overriding workflow execution form properties #2054

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

batzionb
Copy link
Contributor

@batzionb batzionb commented Aug 14, 2024

Includes two new packages:

orchestrator-form-api: will be used by the customer to implement a factory that overrides the workflow execution from properties.
orchestrator-form: decoupled from orchestrator to enable customer to test the factory independently.

@batzionb batzionb requested review from a team as code owners August 14, 2024 11:06
@openshift-ci openshift-ci bot requested review from 04kash and JessicaJHee August 14, 2024 11:06
@batzionb batzionb force-pushed the extendedform branch 3 times, most recently from 311829e to 1d6d21d Compare August 14, 2024 12:49
Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1. No new plugins should be added to Janus-IDP. 🛑

Your choices are:

@nickboldt
Copy link
Member

I have been overruled so this can be merged.
Tracking the MSR manual release dance in https://issues.redhat.com/browse/RHIDP-3651

Copy link

@nickboldt nickboldt merged commit 757dd44 into janus-idp:main Aug 15, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants