feat(deps): update to backstage 1.31 #2335

schultzp2020 · 2024-10-09T19:18:28Z

fixes https://issues.redhat.com/browse/RHIDP-3904
fixes: https://issues.redhat.com/browse/RHIDP-4241

Signed-off-by: Paul Schultz <[email protected]>

…into issue-3904 Signed-off-by: Paul Schultz <[email protected]>

Signed-off-by: Paul Schultz <[email protected]>

yashoswalyo

LGTM

…into issue-3904

Signed-off-by: Paul Schultz <[email protected]>

…into issue-3904 Signed-off-by: Paul Schultz <[email protected]>

…into issue-3904

AndrienkoAleksandr

rbac-backend plugins is broken. IdentityService and TokenManager removed and replaced with AuthService and HttpAuthService: backstage/backstage#26120 . We need to fix this code.

schultzp2020 · 2024-10-11T04:39:19Z

rbac-backend plugins is broken. IdentityService and TokenManager removed and replaced with AuthService and HttpAuthService: backstage/backstage#26120 . We need to fix this code.

This should already be fixed here. Am I missing something?

mareklibra · 2024-10-15T08:29:10Z

Needs rebase.

Anyway, when trying as it is, I see error when loading permissions at startup.
The landing page /catalog is failing on an exception.
The Orchestrator is broken, most probably transitively to the issues ^^^.

AndrienkoAleksandr · 2024-10-15T09:49:35Z

This should already be fixed here. Am I missing something?

I think fixed only compilation. Code doesn't work in runtime.

…into issue-3904

…lugins into issue-3904

Signed-off-by: Paul Schultz <[email protected]>

karthikjeeyar · 2024-10-17T07:40:37Z

Tested Tekton, Quay and Lightspeed plugins

/lgtm

mareklibra · 2024-10-17T08:09:31Z

Retested with recent content of this PR and the orchestrator works well.

/lgtm

its-mitesh-kumar · 2024-10-17T09:33:21Z

Tested Topology
/lgtm

Screen.Recording.2024-10-17.at.3.00.58.PM.mov

debsmita1 · 2024-10-17T09:43:01Z

Tested bulk import plugin
/lgtm

its-mitesh-kumar · 2024-10-17T12:28:41Z

Tested RBAC plugin
/lgtm

schultzp2020 · 2024-10-17T15:10:27Z

/override "SonarCloud Code Analysis"

openshift-ci · 2024-10-17T15:10:37Z

@schultzp2020: Overrode contexts on behalf of schultzp2020: SonarCloud Code Analysis

In response to this:

/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

schultzp2020 · 2024-10-17T15:11:11Z

/override "Playwright tests / Run Playwright Tests"

Individual teams will need to fix the UI tests since we are past the deadline.

openshift-ci · 2024-10-17T15:11:14Z

@schultzp2020: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

Playwright tests / Run Playwright Tests

Only the following failed contexts/checkruns were expected:

Build with Node.js 20
Conventional Commits
Test with Node.js 20
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Playwright tests / Run Playwright Tests"

Individual teams will need to fix the UI tests since we are past the deadline.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sonarqubecloud · 2024-10-17T15:11:55Z

Quality Gate failed

Failed conditions
6.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

schultzp2020 · 2024-10-17T15:12:22Z

/override "SonarCloud Code Analysis"

openshift-ci · 2024-10-17T15:12:42Z

@schultzp2020: Overrode contexts on behalf of schultzp2020: SonarCloud Code Analysis

In response to this:

/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

nickboldt

fire in the hole!
ducks and covers

* feat(deps): update to backstage 1.31 Signed-off-by: Paul Schultz <[email protected]> * update todo items Signed-off-by: Paul Schultz <[email protected]> * update yarn lockfile Signed-off-by: Paul Schultz <[email protected]> * fix(rbac): make working rbac-backend with newer APIs (janus-idp#2359) * fix(rbac): make working rbac-backend with newer APIs Signed-off-by: Oleksandr Andriienko <[email protected]> * fit(rbac): fix unit tests Signed-off-by: Oleksandr Andriienko <[email protected]> * fix(rbac): fix lint Signed-off-by: Oleksandr Andriienko <[email protected]> * fix(orchestrator): fix lint Signed-off-by: Oleksandr Andriienko <[email protected]> * fix(rbac): update error type, when httpAuth is not availiable Signed-off-by: Oleksandr Andriienko <[email protected]> --------- Signed-off-by: Oleksandr Andriienko <[email protected]> * add changeset Signed-off-by: Paul Schultz <[email protected]> --------- Signed-off-by: Paul Schultz <[email protected]> Signed-off-by: Oleksandr Andriienko <[email protected]> Co-authored-by: Oleksandr Andriienko <[email protected]>

schultzp2020 added 3 commits October 9, 2024 13:47

feat(deps): update to backstage 1.31

d9e46a5

Signed-off-by: Paul Schultz <[email protected]>

Merge branch 'main' of https://github.com/janus-idp/backstage-plugins …

839002f

…into issue-3904 Signed-off-by: Paul Schultz <[email protected]>

update todo items

1fea928

Signed-off-by: Paul Schultz <[email protected]>

schultzp2020 requested review from a team, rohitkrai03, AndrienkoAleksandr, PatAKnight, debsmita1, divyanshiGupta and fmenesesg as code owners October 9, 2024 19:18

openshift-ci bot requested review from Fortune-Ndlovu and its-mitesh-kumar October 9, 2024 19:18

schultzp2020 changed the title ~~Issue 3904~~ feat(deps): update to backstage 1.31 Oct 9, 2024

yashoswalyo reviewed Oct 9, 2024

View reviewed changes

schultzp2020 added 2 commits October 9, 2024 15:00

Merge branch 'main' of https://github.com/janus-idp/backstage-plugins …

25825f0

…into issue-3904

update yarn lockfile

d16c1d5

Signed-off-by: Paul Schultz <[email protected]>

openshift-merge-robot added the needs-rebase label Oct 10, 2024

Merge branch 'main' of https://github.com/janus-idp/backstage-plugins …

93fd580

…into issue-3904 Signed-off-by: Paul Schultz <[email protected]>

schultzp2020 requested a review from yangcao77 as a code owner October 10, 2024 15:40

openshift-merge-robot removed the needs-rebase label Oct 10, 2024

Merge branch 'main' of https://github.com/janus-idp/backstage-plugins …

606fff3

…into issue-3904

AndrienkoAleksandr reviewed Oct 11, 2024

View reviewed changes

openshift-merge-robot added the needs-rebase label Oct 11, 2024

schultzp2020 added 2 commits October 16, 2024 15:34

Merge branch 'main' of https://github.com/janus-idp/backstage-plugins …

d926845

…into issue-3904

Merge branch 'issue-3904' of https://github.com/janus-idp/backstage-p…

7c78c00

…lugins into issue-3904

openshift-ci bot removed the lgtm label Oct 16, 2024

openshift-merge-robot removed the needs-rebase label Oct 16, 2024

add changeset

92ba56c

Signed-off-by: Paul Schultz <[email protected]>

schultzp2020 requested a review from a team as a code owner October 16, 2024 20:39

openshift-ci bot assigned karthikjeeyar Oct 17, 2024

openshift-ci bot added the lgtm label Oct 17, 2024

openshift-ci bot assigned its-mitesh-kumar Oct 17, 2024

openshift-ci bot assigned debsmita1 Oct 17, 2024

Merge branch 'main' into issue-3904

4aee4db

openshift-ci bot removed the lgtm label Oct 17, 2024

nickboldt approved these changes Oct 17, 2024

View reviewed changes

openshift-ci bot assigned nickboldt Oct 17, 2024

openshift-ci bot added the lgtm label Oct 17, 2024

schultzp2020 merged commit 45903e9 into main Oct 17, 2024
8 of 11 checks passed

schultzp2020 deleted the issue-3904 branch October 17, 2024 16:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(deps): update to backstage 1.31 #2335

feat(deps): update to backstage 1.31 #2335

schultzp2020 commented Oct 9, 2024 •

edited by AndrienkoAleksandr

Loading

yashoswalyo left a comment

AndrienkoAleksandr left a comment

schultzp2020 commented Oct 11, 2024 •

edited

Loading

mareklibra commented Oct 15, 2024

AndrienkoAleksandr commented Oct 15, 2024

karthikjeeyar commented Oct 17, 2024

mareklibra commented Oct 17, 2024 •

edited

Loading

its-mitesh-kumar commented Oct 17, 2024

debsmita1 commented Oct 17, 2024

its-mitesh-kumar commented Oct 17, 2024

schultzp2020 commented Oct 17, 2024

openshift-ci bot commented Oct 17, 2024

schultzp2020 commented Oct 17, 2024

openshift-ci bot commented Oct 17, 2024

sonarqubecloud bot commented Oct 17, 2024

schultzp2020 commented Oct 17, 2024

openshift-ci bot commented Oct 17, 2024

nickboldt left a comment

feat(deps): update to backstage 1.31 #2335

feat(deps): update to backstage 1.31 #2335

Conversation

schultzp2020 commented Oct 9, 2024 • edited by AndrienkoAleksandr Loading

yashoswalyo left a comment

Choose a reason for hiding this comment

AndrienkoAleksandr left a comment

Choose a reason for hiding this comment

schultzp2020 commented Oct 11, 2024 • edited Loading

mareklibra commented Oct 15, 2024

AndrienkoAleksandr commented Oct 15, 2024

karthikjeeyar commented Oct 17, 2024

mareklibra commented Oct 17, 2024 • edited Loading

its-mitesh-kumar commented Oct 17, 2024

debsmita1 commented Oct 17, 2024

its-mitesh-kumar commented Oct 17, 2024

schultzp2020 commented Oct 17, 2024

openshift-ci bot commented Oct 17, 2024

schultzp2020 commented Oct 17, 2024

openshift-ci bot commented Oct 17, 2024

sonarqubecloud bot commented Oct 17, 2024

Quality Gate failed

schultzp2020 commented Oct 17, 2024

openshift-ci bot commented Oct 17, 2024

nickboldt left a comment

Choose a reason for hiding this comment

schultzp2020 commented Oct 9, 2024 •

edited by AndrienkoAleksandr

Loading

schultzp2020 commented Oct 11, 2024 •

edited

Loading

mareklibra commented Oct 17, 2024 •

edited

Loading