Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix right-facing wheelchair emojis #125

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

12Me21
Copy link

@12Me21 12Me21 commented Jan 16, 2025

I used a script to generate them from the left-facing originals.

Some of the elements weren't flipped properly before, e.g:


Note: I updated the png renders with:

rsvg-convert -w 72 -h 72 ./assets/svg/"$1".svg -o temp.png
pngquant --speed 1 -f --quality 50 --output ./assets/72x72/"$1".png -- temp.png

which seems to produce similar size/quality to the existing files?

@Nerixyz
Copy link
Contributor

Nerixyz commented Jan 17, 2025

Thank you. Should mention that #77 introduced this. Seems like an imagemagick bug.

Some of the elements weren't flipped properly before

Some of the images weren't generated properly before

@12Me21
Copy link
Author

12Me21 commented Jan 17, 2025

Thank you. Should mention that #77 introduced this. Seems like an imagemagick bug.

oh I should clarify, this is an issue with the svg files themselves. (the png renders were accurate to the svgs)
the problem seems to be that they added a transform attribute to all elements, including <g>, which means the flip got applied twice to any nested elements (like, <g transform="…"><circle transform="…"/>…</g> etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants