Inline jenkins-stapler-support
#10189
Open
+203
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of annotation classes live in a separate
jenkins-stapler-support
library at https://github.com/jenkinsci/lib-jenkins-stapler-support, which hasn't been maintained in 6 years. I can't imagine anything other than Jenkins core consuming this library, and having it in a separate repository adds to the burden of maintaining it, so why not inline it into Jenkins core as we did withextras-executable-war
a few years back. Its tests live in this repository anyway, so this unites the code with its tests, which is also a good thing. If this PR is accepted, I will archive thejenkins-stapler-support
repository once it is no longer consumed by any LTS release.Testing done
mvn clean verify -Dtest=jenkins.security.stapler.CustomRoutingDecisionProviderTest,jenkins.security.stapler.DoActionFilterTest,jenkins.security.stapler.DynamicTest,jenkins.security.stapler.GetterMethodFilterTest,jenkins.security.stapler.JenkinsSupportAnnotationsTest,jenkins.security.stapler.PreventRoutingTest,jenkins.security.stapler.Security400Test,jenkins.security.stapler.Security867Test,jenkins.security.stapler.Security914Test,jenkins.security.stapler.StaplerAbstractTest,jenkins.security.stapler.StaplerDispatchValidatorTest,jenkins.security.stapler.StaplerRoutableActionTest,jenkins.security.stapler.StaplerRoutableFieldTest,jenkins.security.stapler.StaplerRoutableGetterTest,jenkins.security.stapler.StaplerSignaturesTest,jenkins.security.stapler.StaticRoutingDecisionProvider2Test,jenkins.security.stapler.StaticRoutingDecisionProviderTest,jenkins.security.stapler.TypedFilterTest
Proposed changelog entries
N/A
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist