-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-43786] Overhaul of Manage Jenkins page #2857
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
7dbaf5f
[JENKINS-43786] Initial source code modifications
recena 52654eb
[JENKINS-43786] Adding a customized Bootstrap version and some messag…
recena d8b4526
Merge branch 'master' of https://github.com/jenkinsci/jenkins into JE…
recena 8774f3c
[JENKINS-43786] Some Monitors included in the core have been adapted
recena beaf805
[JENKINS-43786] Rebasing with master
recena 7dd0429
[JENKINS-43786] Reverting an unexisting typo
recena a4b4771
[JENKINS-43786] Applying final styles
recena 427ab29
[JENKINS-43786] Addressing more use cases
recena 7de4a81
[JENKINS-43786] Revisiting how the buttons are shown
recena 5c14800
[JENKINS-43786] Adjustments in the administrative monitor pop-up
recena 672af73
[JENKINS-43786] Added more use cases related with administrative mess…
recena 8126460
[JENKINS-43786] Adapted the Administrative Monitors provided by Jenki…
recena 9485c88
[JENKINS-43786] Addressed the @daniel-beck's review
recena 31bfe00
[JENKINS-43786] Wrong indent
recena bcae594
[JENKINS-43786] Better semantic HTML
recena 20461b2
[JENKINS-43786] Better semantic HTML
recena 317c734
[JENKINS-43786] Applying the same criteria for listing items
recena e93c464
[JENKINS-43786] Adapted tests
recena 9f2304a
[JENKINS-43786] Removing redirect links in the administrative monitor…
recena 077bbd8
[JENKINS-43786] Adapted Administrative Monitor
recena b3acf08
[JENKINS-43786] Reverted Redirect URLs
recena af73959
[JENKINS-43786] Applying the same code style
recena a398fff
[JENKINS-43786] Applying the same code style
recena 4735288
Merge branch 'master' into JENKINS-43786
recena a93b2d6
[JENKINS-43786] Apply a common HTML markup to the Administrative Moni…
recena bae6127
Merge branch 'JENKINS-43786' of https://github.com/recena/jenkins int…
recena cc25e51
[JENKINS-43786] One more Administrative Monitor updated
recena f49131b
[JENKINS-43786] Polishing some details
recena 849938f
[JENKINS-43786] Deprecating CSS Styles
recena 9a175ab
[JENKINS-43786] We are ready for deprecating anything
recena 4641644
[JENKINS-43786] We are ready for deprecating anything
recena d6395f1
[JENKINS-43786] Details
recena 5fc308d
Merge branch 'master' of https://github.com/jenkinsci/jenkins into JE…
recena File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 14 additions & 19 deletions
33
.../src/main/resources/hudson/PluginWrapper/PluginWrapperAdministrativeMonitor/message.jelly
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,17 @@ | ||
<?jelly escape-by-default='true'?> | ||
<j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form"> | ||
<div class="error"> | ||
<form method="post" action="${rootURL}/${it.url}/act" name="${it.id}"> | ||
<div style="float:right"> | ||
<f:submit name="correct" value="${%Correct}"/> | ||
</div> | ||
</form> | ||
${%Dependency errors}: | ||
<ul> | ||
<j:forEach items="${it.plugins}" var="plugin"> | ||
<li>${plugin.longName} v${plugin.version} | ||
<ul> | ||
<j:forEach items="${plugin.dependencyErrors}" var="d"> | ||
<li>${d}</li> | ||
</j:forEach> | ||
</ul> | ||
</li> | ||
</j:forEach> | ||
</ul> | ||
</div> | ||
<div class="alert alert-danger" role="alert"> | ||
<form method="post" action="${rootURL}/${it.url}/act" name="${it.id}"> | ||
<f:submit name="correct" value="${%Correct}"/> | ||
</form> | ||
${%Dependency errors} | ||
<j:forEach items="${it.plugins}" var="plugin"> | ||
<dl> | ||
<dt>${plugin.longName} v${plugin.version}</dt> | ||
<j:forEach items="${plugin.dependencyErrors}" var="d"> | ||
<dd>${d}</dd> | ||
</j:forEach> | ||
</dl> | ||
</j:forEach> | ||
</div> | ||
</j:jelly> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
core/src/main/resources/hudson/diagnosis/HudsonHomeDiskUsageMonitor/message.properties
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
blurb=Your Jenkins data directory "{0}" (AKA <tt>JENKINS_HOME</tt>) is almost full. You should act on it before it gets completely full. | ||
blurb=Your Jenkins data directory <code>{0}</code> (AKA <code>JENKINS_HOME</code>) is almost full. You should act on it before it gets completely full. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
core/src/main/resources/hudson/diagnosis/NullIdDescriptorMonitor/message.properties
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
blurb=The following extensions have no ID value and therefore likely cause a problem. Please upgrade these plugins if they are not the latest, \ | ||
and if they are the latest, please file a bug so that we can fix them. | ||
and if they are the latest, please file a bug so that we can fix them | ||
problem=Descriptor {0} from plugin {2} with display name {1} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 3 additions & 4 deletions
7
core/src/main/resources/jenkins/diagnostics/CompletedInitializationMonitor/message.jelly
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
style
attribute is still here for keeping the current behavior but I would like to revisit this part in midterm.