8322734: A redundant return in method padWithLen

Reviewed-by: jiefu
johnshajiang · Dec 27, 2023 · 2a59243 · 2a59243
1 parent 4fc6b0f
commit 2a59243
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/src/java.base/share/classes/com/sun/crypto/provider/ISO10126Padding.java b/src/java.base/share/classes/com/sun/crypto/provider/ISO10126Padding.java
@@ -74,7 +74,6 @@ public void padWithLen(byte[] in, int off, int len)
         SunJCE.getRandom().nextBytes(padding);
         System.arraycopy(padding, 0, in, off, len - 1);
         in[idx - 1] = paddingOctet;
-        return;
     }
 
     /**

diff --git a/src/java.base/share/classes/com/sun/crypto/provider/PKCS5Padding.java b/src/java.base/share/classes/com/sun/crypto/provider/PKCS5Padding.java
@@ -71,7 +71,6 @@ public void padWithLen(byte[] in, int off, int len)
 
         byte paddingOctet = (byte) (len & 0xff);
         Arrays.fill(in, off, idx, paddingOctet);
-        return;
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -74,7 +74,6 @@ public void padWithLen(byte[] in, int off, int len) @@
             SunJCE.getRandom().nextBytes(padding);
             System.arraycopy(padding, 0, in, off, len - 1);
             in[idx - 1] = paddingOctet;
-            return;
         }
         /**
@@ Expand Down @@