Don't use exhausted nextToken #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems the AWS API changed so that if you specify a nextToken that you've already used, you don't actually get new results (and a new nextToken). This patch simply drops the nextToken from the request after it's been used (which appears to fix the `--watch` behaviour at least for me).
|
Thanks @martynsmith for the patch. I understand the problem you are explaining... but I'm not sure removing the I wonder if the correct solution would involve keeping track of the latest |
|
Hmm, it appears to be working for me locally, but perhaps that's just because you're dropping duplicate lines?
…On 30 Jul 2017, 4:18 AM +1200, Jorge Bastida ***@***.***>, wrote:
Thanks @martynsmith for the patch. I understand the problem you are explaining... but I'm not sure removing the next_token will solve the issue. My understanding is that the following request after removing the token, aws will start over sending events from the beginning.
I wonder if the correct solution would involve keeping track of the latest timestamp of the response events, and once one of the response comes empty, remove the next_token and use the latest timestamp as the starting point.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@jorgebastida I've implemented a fix according to your suggestion, and it seems to address the issue quite well. If there's interest I'll prepare a PR. |
|
@gavrie Yes please! |
|
I think #196 also fixes what this PR here provides/does. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the AWS API changed so that if you specify a nextToken that you've already used, you don't actually get new results (and a new nextToken).
This patch simply drops the nextToken from the request after it's been used (which appears to fix the
--watchbehaviour at least for me).While I haven't completely read the existing bugs and pull requests for this, this seems like a relatively minor tweak to make the watch behaviour work again. (related are #74 and #62)