Also add missing operators on row iterator.

NEWS

@@ -2,7 +2,8 @@
  - Fix possible crash in `connection::connection_string` (#290).
  - Fix filtering of default values in `connection::connection_string` (#288).
  - Deprecate `row::swap` and public inheritance of iterators from `row`.
- - More copy/move constructors/assignments on result iterators.
+ - More copy/move/default constructors/assignments on result iterators.
+ - More copy/move/default constructors/assignments on row iterators.
 7.0.3
  - Fixed misreporting of broken connection as `sql_error` (#280).
  - Replaced non-ASCII test texts with escape codes (#282, #283).

include/pqxx/field.hxx

@@ -41,6 +41,8 @@ public:
    */
   field(row const &r, row_size_type c) noexcept;
 
+  field() = default;
+
   /**
    * @name Comparison
    */

include/pqxx/row.hxx

@@ -215,8 +215,11 @@ public:
   using difference_type = row_difference_type;
   using reference = field;
 
+  const_row_iterator() = default;
   const_row_iterator(row const &T, row_size_type C) noexcept : field{T, C} {}
   const_row_iterator(field const &F) noexcept : field{F} {}
+  const_row_iterator(const_row_iterator const &) = default;
+  const_row_iterator(const_row_iterator &&) = default;
 
   /**
    * @name Dereferencing operators
@@ -230,6 +233,9 @@ public:
    * @name Manipulations
    */
   //@{
+  const_row_iterator &operator=(const_row_iterator const &) = default;
+  const_row_iterator &operator=(const_row_iterator &&) = default;
+
   const_row_iterator operator++(int);
   const_row_iterator &operator++()
   {
@@ -313,7 +319,10 @@ public:
   using value_type = iterator_type::value_type;
   using reference = iterator_type::reference;
 
-  const_reverse_row_iterator(const_reverse_row_iterator const &r) = default;
+  const_reverse_row_iterator() = default;
+  const_reverse_row_iterator(const_reverse_row_iterator const &) = default;
+  const_reverse_row_iterator(const_reverse_row_iterator &&) = default;
+
   explicit const_reverse_row_iterator(super const &rhs) noexcept :
           const_row_iterator{rhs}
   {

test/unit/test_row.cxx

@@ -22,5 +22,36 @@ void test_row()
 }
 
 
+void test_row_iterator()
+{
+  pqxx::connection conn;
+  pqxx::work tx{conn};
+  pqxx::result rows{tx.exec("SELECT 1, 2, 3")};
+
+  auto i{rows[0].begin()};
+  PQXX_CHECK_EQUAL(i->as<int>(), 1, "Row iterator is wrong.");
+  auto i2{i};
+  PQXX_CHECK_EQUAL(i2->as<int>(), 1, "Row iterator copy is wrong.");
+  i2++;
+  PQXX_CHECK_EQUAL(i2->as<int>(), 2, "Row iterator increment is wrong.");
+  pqxx::row::const_iterator i3;
+  i3 = i2;
+  PQXX_CHECK_EQUAL(i3->as<int>(), 2, "Row iterator assignment is wrong.");
+
+  auto r{rows[0].rbegin()};
+  PQXX_CHECK_EQUAL(r->as<int>(), 3, "Row reverse iterator is wrong.");
+  auto r2{r};
+  PQXX_CHECK_EQUAL(r2->as<int>(), 3, "Row reverse iterator copy is wrong.");
+  r2++;
+  PQXX_CHECK_EQUAL(
+    r2->as<int>(), 2, "Row reverse iterator increment is wrong.");
+  pqxx::row::const_reverse_iterator r3;
+  r3 = r2;
+  PQXX_CHECK_EQUAL(
+    i3->as<int>(), 2, "Row reverse iterator assignment is wrong.");
+}
+
+
 PQXX_REGISTER_TEST(test_row);
+PQXX_REGISTER_TEST(test_row_iterator);
 } // namespace