Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: Make native warped components persist #274

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Conversation

synchon
Copy link
Member

@synchon synchon commented Nov 7, 2023

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR makes native warped components (parcellations, coordinates and masks) persist after the warping is complete via element-scoped tempdirs and tempfiles. This is needed due to nibabel and numpy caching file paths for computation later.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #274 (c507cfc) into main (124c175) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
- Coverage   90.08%   90.04%   -0.05%     
==========================================
  Files          90       90              
  Lines        4116     4118       +2     
  Branches      811      811              
==========================================
  Hits         3708     3708              
- Misses        284      286       +2     
  Partials      124      124              
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 90.04% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
junifer/preprocess/fsl/bold_warper.py 72.72% <ø> (ø)
junifer/data/coordinates.py 70.76% <0.00%> (ø)
junifer/data/masks.py 82.73% <0.00%> (-0.60%) ⬇️
junifer/data/parcellations.py 88.59% <0.00%> (-0.20%) ⬇️

@synchon synchon requested a review from fraimondo November 7, 2023 13:30
@synchon synchon added bug Something isn't working parcellation Issues or pull requests related to parcellations (atlases) coordinate Issues or pull requests related to coordinates (ROIs) mask Issues or pull requests related to masks labels Nov 7, 2023
Copy link

github-actions bot commented Nov 7, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-11-07 14:51 UTC

@synchon synchon merged commit 69d17a7 into main Nov 7, 2023
16 of 20 checks passed
@synchon synchon deleted the fix/nibabel-cache-bypass branch November 7, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working coordinate Issues or pull requests related to coordinates (ROIs) mask Issues or pull requests related to masks parcellation Issues or pull requests related to parcellations (atlases)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants