Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Move data downloading/handling to junifer-data package. #363

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

synchon
Copy link
Member

@synchon synchon commented Jan 21, 2025

Are you requiring a new dataset or marker?

  • I understand this is not a marker or dataset request

Which feature do you want to include?

Currently, Junifer is handling the data, downloading from various sources. Ideally, this should be centralized and versiones.

How do you imagine this integrated in junifer?

  1. Junifer uses the junifer-data API.
  2. junifer-data keeps a datalad dataset with all data objects, including externals. Each commit to this datasets has a tag.
  3. junifer knows exactly which is the tag that we are dealing with, so each junifer version will always work with the same data files.
  4. We have a command download or similar that makes junifer download all (or the requested) files to be used later on with the run command.

Do you have a sample code that implements this outside of junifer?

No response

Anything else to say?

No response

@fraimondo fraimondo added enhancement New feature or request triage New issues waiting to be reviewed labels Sep 24, 2024
@fraimondo fraimondo added this to the 0.0.6 (alpha 5) milestone Sep 24, 2024
@fraimondo fraimondo removed the triage New issues waiting to be reviewed label Sep 24, 2024
@fraimondo fraimondo changed the title [ENH]: Move data downlading/handling to junifer-data package. [ENH]: Move data downloading/handling to junifer-data package. Sep 24, 2024
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 62 lines in your changes missing coverage. Please review.

Project coverage is 0.01%. Comparing base (fd8cfc2) to head (81ced3b).

Files with missing lines Patch % Lines
junifer/data/parcellations/_parcellations.py 0.00% 40 Missing ⚠️
junifer/data/masks/_masks.py 0.00% 11 Missing ⚠️
junifer/data/coordinates/_coordinates.py 0.00% 7 Missing ⚠️
junifer/data/utils.py 0.00% 3 Missing ⚠️
junifer/data/template_spaces.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##            main    #363    +/-   ##
======================================
  Coverage   0.01%   0.01%            
======================================
  Files        133     133            
  Lines       5764    5558   -206     
======================================
  Hits           1       1            
+ Misses      5763    5557   -206     
Flag Coverage Δ
docs 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
junifer/typing/_typing.py 0.00% <ø> (ø)
junifer/data/template_spaces.py 0.00% <0.00%> (ø)
junifer/data/utils.py 0.00% <0.00%> (ø)
junifer/data/coordinates/_coordinates.py 0.00% <0.00%> (ø)
junifer/data/masks/_masks.py 0.00% <0.00%> (ø)
junifer/data/parcellations/_parcellations.py 0.00% <0.00%> (ø)

@synchon synchon added parcellation Issues or pull requests related to parcellations (atlases) coordinate Issues or pull requests related to coordinates (ROIs) mask Issues or pull requests related to masks labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coordinate Issues or pull requests related to coordinates (ROIs) enhancement New feature or request mask Issues or pull requests related to masks parcellation Issues or pull requests related to parcellations (atlases)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants