Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Add scrubbing support in fMRIPrepConfoundRemover #421

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

synchon
Copy link
Member

@synchon synchon commented Jan 23, 2025

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR adds scrubbing support in fMRIPrepConfoundRemover by using std_dvars from fMRIPrep output.

@synchon synchon added preprocess Issues or pull requests related to preprocessors enhancement New feature or request labels Jan 23, 2025
@synchon synchon added this to the 0.0.6 (alpha 5) milestone Jan 23, 2025
@synchon synchon requested a review from fraimondo January 23, 2025 18:33
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.01%. Comparing base (fd8cfc2) to head (72e7ee7).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #421   +/-   ##
=====================================
  Coverage   0.01%   0.01%           
=====================================
  Files        133     133           
  Lines       5764    5764           
=====================================
  Hits           1       1           
  Misses      5763    5763           
Flag Coverage Δ
docs 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../preprocess/confounds/fmriprep_confound_remover.py 0.00% <ø> (ø)

@@ -404,6 +423,14 @@ def _pick_confounds(self, input: dict[str, Any]) -> pd.DataFrame:
out_df["spike"] = fd
to_select.append("spike")

# add binary std_dvars regressor if needed at given threshold
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std_dvars should not be added as a regressor to perform scrubbing, but used to generate a mask that is then passed on to signal.clean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request preprocess Issues or pull requests related to preprocessors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants