-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple sessions in one kernel bug #451
base: main
Are you sure you want to change the base?
Fix multiple sessions in one kernel bug #451
Conversation
It seems the tests are already broken. Will we be able to merge my PR or do I need to fix the tests? |
Thanks @rakhmaevao, I'll look at this in the coming days. |
@davidbrochart any progress? |
kernel_name = kernels[kernel_id]["name"] | ||
kernel_server = KernelServer( | ||
connection_file=self.kernel_id_to_connection_file[kernel_id], | ||
write_connection_file=False, | ||
) | ||
kernels[kernel_id]["server"] = kernel_server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's an external kernel, you want to create the kernel server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created it in line 186. Or did I misunderstand you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's created but not registered in kernels
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I got you.
You're asking why I removed the server with the kernel cache.
I did this because otherwise an error occurs when rebooting the kernel if we have several sessions in the running kernel.
I found the following error
How to reproduce the bug?
Expected behavior
The session will be added
Actual behavior
Error (see below).
Screencast.from.2024-12-11.15-04-34.mp4
How did I fix it?
Confirmation of functionality
Screencast.from.2024-12-11.15-07-36.mp4