Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Python and JavaScript packages #1168

Merged
merged 25 commits into from
Jan 16, 2024
Merged

Split Python and JavaScript packages #1168

merged 25 commits into from
Jan 16, 2024

Conversation

gjmooney
Copy link
Contributor

Split package into separate front end and back end packages based on #1163

martinRenou
martinRenou reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me so far! Thanks!

python/ipyleaflet/pyproject.toml Show resolved Hide resolved
python/ipyleaflet/pyproject.toml Outdated Show resolved Hide resolved
python/ipyleaflet_core/pyproject.toml Show resolved Hide resolved
python/ipyleaflet_core/pyproject.toml Outdated Show resolved Hide resolved
python/jupyter_leaflet/pyproject.toml Show resolved Hide resolved
python/jupyter_leaflet/pyproject.toml Outdated Show resolved Hide resolved
@martinRenou
Copy link
Member

FYI @maartenbreddels

maartenbreddels
maartenbreddels reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@maartenbreddels maartenbreddels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, also @mariobuikhuizen might be interested in this.

Note that we can still have a ipyleaflet-core pypi package installing a python ipyleaflet package, and the metapackage (ipyleaflet) doesn't need to install any code.

In my experience the from ipyleaflet_core import * doesn't work that nicely in practice. It will also break from ipyleaflet.<somemodule> import SomeClass.

Great and brave work ! 👍

jupyter-leaflet.json Outdated Show resolved Hide resolved
@martinRenou
Copy link
Member

installing a python ipyleaflet package

Indeed we were wondering about this yesterday.

In my experience the from ipyleaflet_core import * doesn't work that nicely in practice. It will also break from ipyleaflet. import SomeClass.

Good point indeed! We should definitely do that then.

@martinRenou
Copy link
Member

Seems to be working great on the JupyterLite deployment in the docs!

Screenshot from 2024-01-12 10-28-15

@maartenbreddels
Copy link
Member

Nice, and here you only installed ipyleaflet-core?

@martinRenou
Copy link
Member

Nice, and here you only installed ipyleaflet-core?

Indeed. We should install the metapackage there too.

martinRenou
martinRenou reviewed Jan 12, 2024
View reviewed changes
docs/environment.yml Show resolved Hide resolved
docs/build-environment.yml Show resolved Hide resolved
@gjmooney gjmooney marked this pull request as ready for review January 12, 2024 16:05
martinRenou
martinRenou approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou changed the title Split packages Split Python and JavaScript packages Jan 16, 2024
@martinRenou martinRenou merged commit 78ba5f7 into jupyter-widgets:master Jan 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maartenbreddels maartenbreddels maartenbreddels left review comments

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gjmooney @martinRenou @maartenbreddels