feat(core): [Network Tokenization] pre network tokenization #6873

ImSagnik007 · 2024-12-18T06:19:09Z

Type of Change

Description

Introduced a new field in business_profile (is_pre_network_tokenization_enabled).
Based on that field the card will be tokenized before first payment.
If the payment get succeeded the card and network token data will be stored in the locker afterwards.

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

semanticdiff-com · 2024-12-18T06:19:12Z

Review changes with

Changed Files

File	Status
crates/router/src/core/payment_methods/network_tokenization.rs	80% smaller
crates/router/src/core/payments/tokenization.rs	34% smaller
api-reference-v2/openapi_spec.json	19% smaller
api-reference/openapi_spec.json	19% smaller
crates/api_models/src/admin.rs	0% smaller
crates/diesel_models/src/business_profile.rs	0% smaller
crates/diesel_models/src/schema.rs	0% smaller
crates/diesel_models/src/schema_v2.rs	0% smaller
crates/hyperswitch_domain_models/src/business_profile.rs	0% smaller
crates/router/src/core/admin.rs	0% smaller
crates/router/src/core/payments.rs	0% smaller
crates/router/src/core/payments/operations/payment_approve.rs	0% smaller
crates/router/src/core/payments/operations/payment_cancel.rs	0% smaller
crates/router/src/core/payments/operations/payment_capture.rs	0% smaller
crates/router/src/core/payments/operations/payment_complete_authorize.rs	0% smaller
crates/router/src/core/payments/operations/payment_confirm.rs	0% smaller
crates/router/src/core/payments/operations/payment_create.rs	0% smaller
crates/router/src/core/payments/operations/payment_post_session_tokens.rs	0% smaller
crates/router/src/core/payments/operations/payment_reject.rs	0% smaller
crates/router/src/core/payments/operations/payment_response.rs	0% smaller
crates/router/src/core/payments/operations/payment_session.rs	0% smaller
crates/router/src/core/payments/operations/payment_start.rs	0% smaller
crates/router/src/core/payments/operations/payment_status.rs	0% smaller
crates/router/src/core/payments/operations/payment_update.rs	0% smaller
crates/router/src/core/payments/operations/payments_incremental_authorization.rs	0% smaller
crates/router/src/core/payments/operations/tax_calculation.rs	0% smaller
crates/router/src/types/api/admin.rs	0% smaller
migrations/2025-01-22-110625_add_is_pre_network_tokenization_enabled_in_business_profile/down.sql	Unsupported file format
migrations/2025-01-22-110625_add_is_pre_network_tokenization_enabled_in_business_profile/up.sql	Unsupported file format

prasunna09

also when constructing router data, if pre-tokenization enabled, we need to pass network token data as payment method data. Could you point me to that change?

prasunna09 · 2024-12-27T10:56:46Z

crates/router/src/core/payments.rs

+                    if is_pre_tokenization_enabled && is_nt_supported_connector_available {
+                        let pre_tokenization_response = tokenization::pre_payment_tokenization(


can this validation for pre-network tokenization move to a a function?

prasunna09 · 2024-12-27T10:58:27Z

crates/router/src/core/payments.rs

+                        .await?;
+                        let pm_data = payment_data.get_payment_method_data();
+                        match pre_tokenization_response {
+                            (Some(token_response), Some(_token_ref)) => {


why are we ignoring this token_ref? this should be set in payment method info right?

prasunna09 · 2024-12-27T11:04:12Z

crates/router/src/core/payments.rs

+                    let filtered_nt_supported_connectors =
+                        get_filtered_nt_supported_connectors(&state, [connector.clone()].to_vec());
+
+                    let is_nt_supported_connector_available =
+                        filtered_nt_supported_connectors.first().is_some();


do no filter out. check only if the connector decided by routing is in the network tokenization supported connectors. this is because routing should always be prioritized over any feature. please remove this.

prasunna09 · 2024-12-27T11:06:43Z

crates/router/src/core/payments.rs

+                        match pre_tokenization_response {
+                            (Some(token_response), Some(_token_ref)) => {
+                                let token_data = domain::NetworkTokenData {


since this is same logic, can you write this to a common function?

prasunna09 · 2025-01-13T07:21:44Z

crates/api_models/src/admin.rs

+
+    /// Indicates if network tokenization before first payment is enabled or not
+    #[serde(default)]
+    pub is_tokenize_before_payment_enabled: bool,


is_tokenize_before_payment_enabled is bit ambiguous when 'before payment' is mentioned in variable name.

is_pre_network_tokenization_enabled can be used ig. We can add clear doc comment

prasunna09 · 2025-01-13T07:40:49Z

crates/router/src/core/payments.rs

+
+                    let is_nt_supported_connector = ntid_supported_connectors.contains(&connector_data.connector_name);
+
+                    println!("{:?}<<>>10",is_nt_supported_connector);


remove the loggers.

prasunna09 · 2025-01-13T07:41:11Z

crates/router/src/core/payments.rs

+                    println!("{:?}<<>>10",is_nt_supported_connector);
+
+                    if is_pre_tokenization_enabled && is_nt_supported_connector {
+                        println!("{:?}<<>>14",is_nt_supported_connector);


prasunna09 · 2025-01-13T07:41:28Z

crates/router/src/core/payments.rs

+                    if is_pre_tokenization_enabled && is_nt_supported_connector {
+                        println!("{:?}<<>>14",is_nt_supported_connector);
+                        save_card_and_network_token_data(state, &mut payment_data).await;
+                        println!("{:?}<<>>15",payment_data.get_payment_method_data());


remove this too^

prasunna09 · 2025-01-13T07:42:45Z

crates/router/src/core/payments.rs

+                network_token_data: token_data.clone(),
+                ref_id: token_ref
+            };
+            println!("{:?}<<>>17", network_token_data_for_vault);


remove logger here^

prasunna09 · 2025-01-13T08:39:52Z

crates/router/src/core/payments.rs

+#[derive(Default, Clone, serde::Serialize, Debug)]
+pub struct NetworkTokenDataForVault {
+    pub network_token_data: hyperswitch_domain_models::payment_method_data::NetworkTokenData,
+    pub ref_id: String,


this is network_token_req_ref id right?
Can you rename it?

prasunna09 · 2025-01-13T08:51:15Z

crates/router/src/core/payments.rs

+
+                    if is_pre_tokenization_enabled && is_nt_supported_connector {
+                        println!("{:?}<<>>14",is_nt_supported_connector);
+                        save_card_and_network_token_data(state, &mut payment_data).await;


Can you modify save_card_and_network_token_data fn name? because, the fn is trying to pre tokenize and update payment data.payment method data. but not saving card flow.

prasunna09 · 2025-01-13T08:56:10Z

crates/router/src/core/payments.rs

+}
+
+#[derive(Default, Clone, serde::Serialize, Debug)]
+pub struct CardDataForVault {


seems like this struct has never been used. if this is not needed, can you remove this?

prasunna09 · 2025-01-13T08:57:43Z

crates/router/src/core/payments.rs

+    .await.ok();
+    match pre_tokenization_response {
+        Some((Some(token_response), Some(token_ref))) => {
+            let token_data = domain::NetworkTokenData {


can this be moved to a From implementation?

prasunna09 · 2025-01-13T09:17:50Z

crates/router/src/core/payments/tokenization.rs

+                                        Some(token_response),
+                                        network_token_requestor_ref_id.clone(),
+                                    )),
+                                    _ => Ok((None, None)),


incase fetch cryptogram fails we need to delete the network token generated right?
you return Ok((None, None)) in this failure case.

in save_card_and_network_token_data fn, it is written that if pre_payment_tokenization is None, then vault operation is set to SaveCardData(api::Card). but we need to return network token requestor ref id right? so that we can use this id to delete network token at token requestor in post update tracker

ImSagnik007 self-assigned this Dec 18, 2024

ImSagnik007 requested review from a team as code owners December 18, 2024 06:19

ImSagnik007 linked an issue Dec 18, 2024 that may be closed by this pull request

[FEATURE] [Network Tokenization]: Tokenize before payment #6872

Open

2 tasks

hyperswitch-bot bot added the M-database-changes Metadata: This PR involves database schema changes label Dec 18, 2024

ImSagnik007 force-pushed the pre_network_tokenization branch from 276d588 to 5c13cc8 Compare December 23, 2024 06:06

hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Dec 23, 2024

ImSagnik007 force-pushed the pre_network_tokenization branch from a5845b1 to 3f9c0ba Compare December 23, 2024 08:49

hyperswitch-bot bot removed the M-api-contract-changes Metadata: This PR involves API contract changes label Dec 23, 2024

ImSagnik007 changed the title ~~Pre network tokenization~~ feat(core): [Network Tokenization] pre network tokenization Dec 23, 2024

hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Dec 23, 2024

ImSagnik007 force-pushed the pre_network_tokenization branch from 16e0f52 to dcc8625 Compare December 25, 2024 06:13

hyperswitch-bot bot added M-api-contract-changes Metadata: This PR involves API contract changes and removed M-api-contract-changes Metadata: This PR involves API contract changes labels Dec 25, 2024

prasunna09 requested changes Dec 27, 2024

View reviewed changes

ImSagnik007 force-pushed the pre_network_tokenization branch from 4c8d6a4 to 7563104 Compare January 6, 2025 05:49

hyperswitch-bot bot removed the M-api-contract-changes Metadata: This PR involves API contract changes label Jan 6, 2025

prasunna09 requested changes Jan 13, 2025

View reviewed changes

ImSagnik007 force-pushed the pre_network_tokenization branch 3 times, most recently from d3d4ecf to 90da476 Compare January 20, 2025 09:55

hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Jan 20, 2025

prasunna09 and others added 2 commits January 21, 2025 13:57

add vault operation in payment_data

684df77

pre payment network tokenization

96bf6c4

ImSagnik007 force-pushed the pre_network_tokenization branch from 4b62178 to 6bb59b2 Compare January 21, 2025 11:29

hyperswitch-bot bot added M-api-contract-changes Metadata: This PR involves API contract changes and removed M-api-contract-changes Metadata: This PR involves API contract changes labels Jan 21, 2025

ImSagnik007 force-pushed the pre_network_tokenization branch from a699724 to 9311c2c Compare January 22, 2025 08:59

hyperswitch-bot bot added M-api-contract-changes Metadata: This PR involves API contract changes and removed M-api-contract-changes Metadata: This PR involves API contract changes labels Jan 22, 2025

post payment processing

17f5577

ImSagnik007 force-pushed the pre_network_tokenization branch from e5f5590 to 17f5577 Compare January 22, 2025 11:19

Merge branch 'main' into pre_network_tokenization

51f8872

hyperswitch-bot bot removed the M-api-contract-changes Metadata: This PR involves API contract changes label Jan 22, 2025

docs(openapi): re-generate OpenAPI specification

dc5253f

hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Jan 22, 2025

chore: run formatter

a56539e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): [Network Tokenization] pre network tokenization #6873

feat(core): [Network Tokenization] pre network tokenization #6873

ImSagnik007 commented Dec 18, 2024 •

edited

Loading

semanticdiff-com bot commented Dec 18, 2024 •

edited

Loading

prasunna09 left a comment

prasunna09 Dec 27, 2024

prasunna09 Dec 27, 2024

prasunna09 Dec 27, 2024

prasunna09 Dec 27, 2024

prasunna09 Jan 13, 2025

prasunna09 Jan 13, 2025

prasunna09 Jan 13, 2025

prasunna09 Jan 13, 2025

prasunna09 Jan 13, 2025

prasunna09 Jan 13, 2025

prasunna09 Jan 13, 2025

prasunna09 Jan 13, 2025

prasunna09 Jan 13, 2025

prasunna09 Jan 13, 2025

		if is_pre_tokenization_enabled && is_nt_supported_connector_available {
		let pre_tokenization_response = tokenization::pre_payment_tokenization(


		let is_nt_supported_connector = ntid_supported_connectors.contains(&connector_data.connector_name);

		println!("{:?}<<>>10",is_nt_supported_connector);

feat(core): [Network Tokenization] pre network tokenization #6873

Are you sure you want to change the base?

feat(core): [Network Tokenization] pre network tokenization #6873

Conversation

ImSagnik007 commented Dec 18, 2024 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

semanticdiff-com bot commented Dec 18, 2024 • edited Loading

prasunna09 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ImSagnik007 commented Dec 18, 2024 •

edited

Loading

semanticdiff-com bot commented Dec 18, 2024 •

edited

Loading