Various fixes #540
Merged
Various fixes #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenzap
force-pushed
the
feature-220-fixes
branch
from
9eda6a4 to
dfa46e6
Compare
Otherwise, with ci-phpunit-test, 1st test passes, and next ones will report ErrorException: Undefined variable $db
Useful when user makes use of the ENVIRONMENT / CI_ENV feature which permits to add environment specific config files in 'application/config/ENVIRONMENT/any_file.php' Also required to run tests
Otherwise they would contain the 1st value they had while parsing manually the database configuration. This fixed some issues when running the tests
This is because ALTER TABLE CONVERT TO CHARACTER SET utf8mb4; fails because the column index would be more than 1000 bytes.
tenzap
force-pushed
the
feature-220-fixes
branch
from
dfa46e6 to
3c10660
Compare
PDOStatement::rowCount() is source of problems (used by num_rows() in ci3) See: https://stackoverflow.com/questions/883365/row-count-with-pdo As a consequence, switch to PHP's sqlite3 driver
tenzap
force-pushed
the
feature-220-fixes
branch
from
1e761c6 to
84e5879
Compare
kingster
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits