Bump Istio to v1.24.2

[evenh]

I've removed the negated matching for /.well-known/acme-challenge/ since it now fails validation (probably since Istio 1.23). See istio/istio#27643 (comment).

When testing this configuration manually (by modifying a VirtualService) the more specific Ingress provisioned by cert-manager takes precedence of the more generic VirtualServicees provisioned by skiperator.

Summary by CodeRabbit

• Dependency Updates

  • Upgraded Istio API and client-go dependencies from v1.22.3 to v1.24.2

• Configuration Changes

  • Removed withoutHeaders conditions from VirtualService configurations across multiple test and application files
  • Simplified HTTP to HTTPS redirection rules
  • Updated some hostname configurations in routing resources

• Test Resources

  • Added new Certificate and Gateway resources for additional domain support
  • Updated NetworkPolicy configurations for routing

[coderabbitai]

Walkthrough

The pull request introduces modifications to the Go module dependencies and Istio VirtualService configurations across multiple files. The primary changes involve upgrading Istio library versions in the go.mod file from v1.22.3 to v1.24.2 and removing the withoutHeaders header match conditions in various VirtualService configurations. These changes simplify the routing rules for HTTP requests, particularly for ACME challenge paths, and update the project's dependency versions.

Changes

File	Change Summary
go.mod	Upgraded Istio dependencies: istio.io/api and istio.io/client-go from v1.22.3 to v1.24.2
pkg/resourcegenerator/istio/virtualservice/application.go	Removed WithoutHeaders field from HTTP route redirection
pkg/resourcegenerator/istio/virtualservice/routing.go	Deleted header match condition for HTTPS redirection
tests/application/*/	Removed withoutHeaders sections from VirtualService configurations
tests/routing/routes/	Simplified VirtualService routing rules by removing header match conditions

Poem

🐰 Hop, skip, and jump through code so bright,
Headers vanish, routes now take flight!
Istio's dance, a version's new song,
Simplifying paths where headers belong.
Code hops forward, clean and light! 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 80be252 and a44d335.

⛔ Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

📒 Files selected for processing (13)

• go.mod (1 hunks)
• pkg/resourcegenerator/istio/virtualservice/application.go (0 hunks)
• pkg/resourcegenerator/istio/virtualservice/routing.go (0 hunks)
• tests/application/custom-certificate/application-duplicate-ingress-assert.yaml (0 hunks)
• tests/application/custom-certificate/application-duplicate-ingress-error.yaml (0 hunks)
• tests/application/ingress/application-assert.yaml (0 hunks)
• tests/application/ingress/application-ingress-multiple-ports-assert.yaml (0 hunks)
• tests/application/ingress/patch-application-change-ingress-assert.yaml (0 hunks)
• tests/routing/routes/patch-application-change-port-assert.yaml (0 hunks)
• tests/routing/routes/patch-routing-change-hostname-assert.yaml (0 hunks)
• tests/routing/routes/patch-routing-change-path-assert.yaml (0 hunks)
• tests/routing/routes/patch-routing-remove-path-assert.yaml (0 hunks)
• tests/routing/routes/routing-assert.yaml (0 hunks)

💤 Files with no reviewable changes (12)

• tests/routing/routes/patch-routing-change-path-assert.yaml
• tests/application/ingress/application-assert.yaml
• pkg/resourcegenerator/istio/virtualservice/routing.go
• pkg/resourcegenerator/istio/virtualservice/application.go
• tests/routing/routes/routing-assert.yaml
• tests/application/custom-certificate/application-duplicate-ingress-error.yaml
• tests/routing/routes/patch-routing-change-hostname-assert.yaml
• tests/application/custom-certificate/application-duplicate-ingress-assert.yaml
• tests/routing/routes/patch-routing-remove-path-assert.yaml
• tests/application/ingress/patch-application-change-ingress-assert.yaml
• tests/application/ingress/application-ingress-multiple-ports-assert.yaml
• tests/routing/routes/patch-application-change-port-assert.yaml

🔇 Additional comments (1)

go.mod (1)

21-22: LGTM! Istio upgrade addresses validation failures.

The upgrade of Istio dependencies from v1.22.3 to v1.24.2 aligns with the PR objectives to fix validation failures for .well-known/acme-challenge/ paths.

Let's verify the compatibility and check for any security advisories:

✅ Verification successful

Istio upgrade to v1.24.2 is safe and compatible with the codebase

Based on the verification results:

• No security vulnerabilities were found for the Istio packages
• The codebase extensively uses Istio APIs and client libraries for various resources (VirtualServices, Gateways, ServiceEntries, etc.)
• All Istio-related imports and dependencies are consistently used across the codebase
• The upgrade from v1.22.3 to v1.24.2 is a minor version bump that maintains backward compatibility

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify Istio version compatibility and security advisories

# Check for any security advisories for Istio
gh api graphql -f query='
{
  securityVulnerabilities(first: 5, ecosystem: GO, package: "istio.io/api") {
    nodes {
      advisory {
        summary
        severity
        publishedAt
      }
      vulnerableVersionRange
      firstPatchedVersion {
        identifier
      }
    }
  }
}'

# Check for any incompatible dependencies
rg -l "istio.io/(api|client-go)" | xargs rg "istio"

Length of output: 11016

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[evenh]

This PR will close #573, #574