Remove modern envs #119
Merged
Remove modern envs #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabeel-
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #108.
Reverts the modern envs from #88 since, per the issue, the browserslist env will be specified by apps as a top-level compiler option now. Hopefully these can be brought back into the preset someday if something like babel/babel#13317 is implemented. Another option is a higher-order Babel preset but I'd like to try to avoid that since it's so far from idiomatic Babel config.
I kept most of the runtime env assertion and the changes to the test suite since they're general, although the format will be ported to #117 shortly. I did remove the browserslistrc file in the fixtures directory in favor of specifying targets explicitly as options, since these resolve equivalently and at that point we're just re-testing
@babel/preset-env. I also removed thebrowserslistEnvdocs since it's just a straight passthrough to the env preset but ideally this should be specified as a top-level compiler option now anyway. I'll add some dual bundle guidance to internal docs.