Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor kensho service auth tests #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor kensho service auth tests #10

wants to merge 1 commit into from

Conversation

azoth-anima
Copy link

This includes no functionality change, but introduces a lot of optimizations with respect to how the tests run:

  • add prompts for OAuth client ID and scopes at top level test script.
  • use relative directory names instead of being hardcoded (so tests can be run outside of repo root).
  • generates ephemeral private keys within each dockerfile.
  • add python dependencies into requirements file.
  • add bash shebang to each bash script.

@azoth-anima
Copy link
Author

Hi @mahyarKensho , please take a look here - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@azoth-anima