Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the rails version ~> 7.0.1 #8

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

tungleduyxyz
Copy link
Contributor

@tungleduyxyz tungleduyxyz commented Jan 30, 2024

This is the issue with Jruby, it’s fine with Ruby 3.1.
Related issues:
rack/rack-session#32
jruby/jruby-openssl#290
The error from CI: https://github.com/killbill/killbill-email-notifications-ui/actions/runs/7705083986/job/20998637973

Copy link
Member

@pierre pierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this go into gemspec?

Regardless, good to merge 👍

@reshmabidikar reshmabidikar merged commit eb6029b into killbill:master Jan 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants