Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to read mpg4/h264 videos without embedding a decoder #1029

Closed
kelson42 opened this issue Dec 30, 2023 · 12 comments
Closed

How to read mpg4/h264 videos without embedding a decoder #1029

kelson42 opened this issue Dec 30, 2023 · 12 comments
Assignees

Comments

@kelson42
Copy link
Collaborator

It should be possible to rely on the decoding library on the OS on both Windows and Linux?!

@mgautierfr
Copy link
Member

Probably not a easy situation. It is mostly a packaging situation.
We never explicitly open a decoding library.
Qt is doing it for us and so the question is how Qt is opening such libraries ?

  • On native packages (rpm, dep, ...), it depends on how Qt has been packaged by the distribution
  • On appimage. The purpose of appimage is to embed most of the thing. Qt is "configured" to search for codec "inside" the appimage.
  • On flathub, we don't compile Qt neither. We are using the KDE runtime (https://invent.kde.org/packaging/flatpak-kde-runtime) and https://github.com/flathub/io.qt.qtwebengine.BaseApp. They probably don't package patented codec for the same reason than us. (And no, we cannot use systems libraries)
  • On windows, we use the Qt installed by AppVeyor in its image. So probably the same issue.

@kelson42
Copy link
Collaborator Author

kelson42 commented Jan 3, 2024

On native packages (rpm, dep, ...), it depends on how Qt has been packaged by the distribution

Therefore not our responsibility. Considering that Debian seems to have the proper codec natively, I guess it could/should be readable everywhere.

  • On appimage. The purpose of appimage is to embed most of the thing. Qt is "configured" to search for codec "inside" the appimage.

I see a double constraint which could be impossible to fix. As long as we don't distribute a lot of appimage, that should be OK.

On flathub, we don't compile Qt neither. We are using the KDE runtime (https://invent.kde.org/packaging/flatpak-kde-runtime) and https://github.com/flathub/io.qt.qtwebengine.BaseApp. They probably don't package patented codec for the same reason than us. (And no, we cannot use systems libraries)

Here, we have anyway no control. But we can encourage Linux users to use proper packages if it is proven to be a problem.

  • On windows, we use the Qt installed by AppVeyor in its image. So probably the same issue.

This is THE real problem and the priority to clarify IMO

@kelson42
Copy link
Collaborator Author

Should wo

  • On windows, we use the Qt installed by AppVeyor in its image. So probably the same issue.

This is THE real problem and the priority to clarify IMO

We should get out of Appveyor anyway and it should be OK with Qt6.5+, see https://wiki.qt.io/QtWebEngine/VideoAcceleration#Qt_WebEngine

@kelson42 kelson42 added Qt Qt related task labels Feb 6, 2024
@kelson42
Copy link
Collaborator Author

kelson42 commented Feb 6, 2024

Blocked by #1033

@kelson42 kelson42 added this to the 2.5.0 milestone Feb 6, 2024
@kelson42
Copy link
Collaborator Author

kelson42 commented Mar 4, 2024

@adamlamar Do you have the opportunity to test against Qt 6.5? On Windows?

@adamlamar
Copy link
Collaborator

I can try the Qt 6.5 upgrade on Linux pretty easily. Last time I was never able to get a local Windows development environment working and had to rely on the Appveyor build. I could try upgrading Appveyor but might be a few weeks before I can get to it.

@kelson42
Copy link
Collaborator Author

kelson42 commented Mar 4, 2024

@adamlamar We are moving to a Github windows runnner, so please don't waste your time with Appveyor.

@adamlamar
Copy link
Collaborator

adamlamar commented Mar 8, 2024

I finally got Qt6.5 compiled from source on Ubuntu 22.04. kiwix-desktop compiles and seems to work fine, although I must be missing compile-time options or optional libraries because the browser window doesn't load images amongst other style problems.

Distribution-compiled Qt6:
Screenshot 2024-03-07 at 9 17 20 PM

My custom Qt6.5:
Screenshot 2024-03-07 at 9 18 54 PM

I read that Ubuntu 24.04 will include Qt6.4 so it may be a while before Qt6.5 is available in most Linux distributions.

The next step will be to try out on Windows.

@kelson42
Copy link
Collaborator Author

kelson42 commented Mar 10, 2024

@adamlamar Strage, with Qt6.2.4 it works fine on my Ubuntu 22.04... But not sure exactly where this Bitcoin wiki ZIM file comes from. The key point of this ticket is that we should be able on Windows to read mp4 (for example https://dev.library.kiwix.org/#lang=&q=mp4) without embedding the decoding library (so should rely on Windows decoding capacity).

@kelson42 kelson42 modified the milestones: 2.5.0, 2.4.0 Jul 28, 2024
@kelson42
Copy link
Collaborator Author

Considering that we have achieve to reach all our objectives with webm/vp9 I don't think this is a priority anymore and will close this issue,

@kelson42 kelson42 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2024
@kelson42 kelson42 unpinned this issue Aug 23, 2024
@kelson42 kelson42 reopened this Dec 11, 2024
@kelson42
Copy link
Collaborator Author

I have to reopen the issue because this issue impacts Zimit.

@kelson42
Copy link
Collaborator Author

kelson42 commented Jan 4, 2025

Finally reclosing in favour of #1276 which is more specifoc about the need... but both issues are linked anyway.

@kelson42 kelson42 closed this as completed Jan 4, 2025
@kelson42 kelson42 removed this from the 2.5.0 milestone Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants