Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to qt6 #1033

Closed
mgautierfr opened this issue Jan 29, 2024 · 4 comments · Fixed by #1046
Closed

Port to qt6 #1033

mgautierfr opened this issue Jan 29, 2024 · 4 comments · Fixed by #1046
Assignees
Labels
Qt Qt related task
Milestone

Comments

@mgautierfr
Copy link
Member

Needed for : kiwix/kiwix-build#594 and #1029

@adamlamar
Copy link
Collaborator

I began looking at this.

  • Ubuntu 22.04 Jammy includes Qt 6.2.4. I am not sure if upgrading to 6.2 will fix all the issues, but it should help.
  • I ran the recommended clazy and it came back mostly with some missing Q_OBJECT macros and a few recommendations to change string handling. When I started to compile with Qt 6.2.4, I ran into a bunch more issues like renamed classes etc.

A few questions:

  1. Will kiwix-desktop need to support compiling for both qt5 and qt6 for a period of time? Looks like I can add version checks
  2. Will we need to support 6.2.4 for distros like debian/ubuntu, and also support 6.3+ for other environments?

@kelson42
Copy link
Collaborator

Very promising!

Will kiwix-desktop need to support compiling for both qt5 and qt6 for a period of time? Looks like I can add version checks

It would be better, but I don't think this would be reasonable to expect this if very conplicated to achieve.

Will we need to support 6.2.4 for distros like debian/ubuntu, and also support 6.3+ for other environments?

Not sure about the differences betwenn 6.2 and 6.5, but we definitly target 6.5 to fix problems related to h264.

@adamlamar
Copy link
Collaborator

Gotcha, I will plan to support both for now, and if it turns out to be too hard then I'll back that out. So far it seems doable with some macro magic.

@adamlamar
Copy link
Collaborator

Here's what I've got so far: #1046

@kelson42 kelson42 mentioned this issue Feb 28, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Qt Qt related task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants