Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CLDX-232): updates for windows signing host #778

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

swickersh
Copy link
Contributor

@swickersh swickersh commented Jan 21, 2025

Describe your changes

-The windows signing host has been migrated to aws. This change modifies the cleanup line and utilizes the windows host parameter

Relevant Jira

CLDX-232

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I have bumped the task/pipeline version string and updated changelog in the relevant README
  • I read CONTRIBUTING.MD and commit formatting

Copy link

openshift-ci bot commented Jan 21, 2025

Hi @swickersh. Thanks for your PR.

I'm waiting for a konflux-ci member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@swickersh swickersh marked this pull request as ready for review January 23, 2025 18:40
@swickersh swickersh requested a review from a team as a code owner January 23, 2025 18:40
@johnbieren
Copy link
Collaborator

/ok-to-test

@johnbieren
Copy link
Collaborator

/ok-to-test

-The windows signing host has been migrated to aws. This change modifies
the cleanup line and utilizes the windows host parameter

Signed-off-by: Scott Wickersham <[email protected]>
Copy link

openshift-ci bot commented Jan 24, 2025

New changes are detected. LGTM label has been removed.

@mmalina mmalina enabled auto-merge (squash) January 24, 2025 09:09
@mmalina
Copy link
Contributor

mmalina commented Jan 24, 2025

/ok-to-test

@mmalina mmalina merged commit d8da8d2 into konflux-ci:development Jan 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants