Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dropout layer from ENAS Trial container to fix E2E tests #2455

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Nov 29, 2024

This should fix E2E tests for ENAS example and unblock other PRs.

I removed the Dropout layer from the model constructor given that it fails for TensorFlow distributed training:

ValueError: creating distributed tf.Variable with aggregation=MEAN and 
a non-floating dtype is not supported, please use a different aggregation or dtype

/assign @kubeflow/wg-training-leads @Electronic-Waste @tariq-hasan

Signed-off-by: Andrey Velichkevich <[email protected]>
Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🎉

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Electronic-Waste, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit dc3398d into kubeflow:master Dec 2, 2024
63 checks passed
@andreyvelich andreyvelich deleted the fix-enas-e2e branch December 2, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants