fix failed tests are depends on external container images

[koba1t]

fix #5319

[k8s-ci-robot]

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[varshaprasad96]

@koba1t Could you elaborate on why we need a separate go mod file and repo for e2e testing? I'm sorry if the question sounds trivial, but I'm still trying to catch up. The issue states:

"I believe this was caused by attempting to run a container image that was built external to this repo and does not support the arm64 architecture."

but I'm just wondering if we need to init a separate repo for just for e2e. And if its just for building the container image, why do we need to do it specifically inside this directory?

[koba1t]

Hi @varshaprasad96
Thanks for your comment.

but I'm just wondering if we need to init a separate repo for just for e2e. And if its just for building the container image

I think we need any container images when testing the KRM container function. And, I think we need separate modules because we need to build small images in tests.

why do we need to do it specifically inside this directory?

I'm just putting the same directory on the source of previous e2e tests container image.

If you need any ideas to improve these tests, Could you tell me that?
I want to know your advice and improve this code!

[varshaprasad96]

@koba1t apologies for missing the ping. For the tests, one option is to init the project in-memory instead on disk, as that could possibly help us to reduce the number of files in the project just for testing purposes. Plus the scaffolded projects are not for users to refer and do not contain much of code making it easier to have templates for them. One option is with mapFs (https://pkg.go.dev/testing/fstest#MapFS). Using this is easier because it let's us map the files and the contents. We could also use TestContainers (https://golang.testcontainers.org/features/build_from_dockerfile/#build-from-dockerfile) to build and use lightweight docker images for test.

I would not like to hold this PR based on the above suggestions though. We can merge this, and create an issue to investigate and follow up with a clean up, if that would make the process easier.

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [koba1t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment