WIP: Switch to lima as Vagrant replacement #1953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
saschagrunert
force-pushed
the
lima
branch
3 times, most recently
from
f52f35e to
83a22a3
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1953 +/- ##
=======================================
Coverage 49.25% 49.25%
=======================================
Files 72 72
Lines 7037 7037
=======================================
Hits 3466 3466
Misses 3437 3437
Partials 134 134 |
saschagrunert
force-pushed
the
lima
branch
4 times, most recently
from
8c68b06 to
c06e474
Compare
|
/retest |
looks like we have e2e failed test |
Yep, working towards that. |
saschagrunert
force-pushed
the
lima
branch
9 times, most recently
from
4bb59db to
5543830
Compare
saschagrunert
force-pushed
the
lima
branch
4 times, most recently
from
754f63b to
59ab77f
Compare
Signed-off-by: Sascha Grunert <[email protected]>
|
There seems to be a networking issue now, locally the tests pass 🤔 |
|
/retest |
|
I'm closing this, it seems that lima is a bit slower on GitHub actions so we're facing timeout issues here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Giving lima a try.
Which issue(s) this PR fixes:
Refers to #1936
Does this PR have test?
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?