Cleanup the apparmor recorder maps after processing

[ccojocar]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Cleans up the apparmor recorder maps after processing.

Which issue(s) this PR fixes:

Does this PR have test?

Yes

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ccojocar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ccojocar]

cc @mhils

[mhils]

LGTM!

[mhils]

func (b *AppArmorRecorder) Unload() {
}

in bpfrecorder_apparmor.go needs to be fixed as well.

[ccojocar]

in bpfrecorder_apparmor.go needs to be fixed as well.

It seems that that closing the module will destroy all the links and also unload the programs from the kernel.

security-profiles-operator/internal/pkg/daemon/bpfrecorder/bpfrecorder.go

Line 887 in b2742f1

b.CloseModule(b.module)

This is what actually happens in module close

security-profiles-operator/vendor/github.com/aquasecurity/libbpfgo/module.go

Line 183 in b2742f1

func (m *Module) Close() {

I'm not sure if we need to do anything extra in the AppArmorRecorder Unload.

[mhils]

I just saw that the seccomp recorder is cleaning itself up in Unload and the AppArmor recorder isn't, which kind of fits the theme of this PR. Not sure if the userspace datastructures survive. :)

[ccojocar]

I just saw that the seccomp recorder is cleaning itself up in Unload and the AppArmor recorder isn't, which kind of fits the theme of this PR. Not sure if the userspace datastructures survive. :)

Got it! I cleaned up all the internal maps in the Unload.

[ccojocar]

Close in favour of #/2675.