bpf: add path_mknod hook
#2668
Merged
bpf: add path_mknod hook
#2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @mhils. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2668 +/- ##
==========================================
- Coverage 45.50% 41.14% -4.37%
==========================================
Files 79 110 +31
Lines 7782 18582 +10800
==========================================
+ Hits 3541 7645 +4104
- Misses 4099 10422 +6323
- Partials 142 515 +373 |
mhils
force-pushed
the
mknod2
branch
4 times, most recently
from
68a7fd9 to
4aa6998
Compare
mhils
added a commit
to mhils/security-profiles-operator
that referenced
this pull request
Jan 15, 2025
…startup This commit makes it so that the BPF program is loaded (and relocated) on profile recorder startup. When we then want to start the recording, we only need to attach the programs. This fixes the flakiness in kubernetes-sigs#2667 and kubernetes-sigs#2668 where program loading is taking so long that we miss container startup.
mhils
added a commit
to mhils/security-profiles-operator
that referenced
this pull request
Jan 15, 2025
…startup This commit makes it so that the BPF program is loaded (and relocated) on profile recorder startup. When we then want to start the recording, we only need to attach the programs. This fixes the flakiness in kubernetes-sigs#2667 and kubernetes-sigs#2668 where program loading is taking so long that we miss container startup.
mhils
added a commit
to mhils/security-profiles-operator
that referenced
this pull request
Jan 15, 2025
…startup This commit makes it so that the BPF program is loaded (and relocated) on profile recorder startup. When we then want to start the recording, we only need to attach the programs. This fixes the flakiness in kubernetes-sigs#2667 and kubernetes-sigs#2668 where program loading is taking so long that we miss container startup.
mhils
added a commit
to mhils/security-profiles-operator
that referenced
this pull request
Jan 15, 2025
…startup This commit makes it so that the BPF program is loaded (and relocated) on profile recorder startup. When we then want to start the recording, we only need to attach the programs. This fixes the flakiness in kubernetes-sigs#2667 and kubernetes-sigs#2668 where program loading is taking so long that we miss container startup.
mhils
added a commit
to mhils/security-profiles-operator
that referenced
this pull request
Jan 16, 2025
…startup This commit makes it so that the BPF program is loaded (and relocated) on profile recorder startup. When we then want to start the recording, we only need to attach the programs. This fixes the flakiness in kubernetes-sigs#2667 and kubernetes-sigs#2668 where program loading is taking so long that we miss container startup.
k8s-ci-robot
added
size/XL
k8s-ci-robot
pushed a commit
that referenced
this pull request
Jan 16, 2025
…startup This commit makes it so that the BPF program is loaded (and relocated) on profile recorder startup. When we then want to start the recording, we only need to attach the programs. This fixes the flakiness in #2667 and #2668 where program loading is taking so long that we miss container startup.
k8s-ci-robot
added
size/M
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
k8s-ci-robot
removed
the
needs-ok-to-test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@mhils This need to be rebased. |
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
lgtm
ccojocar
approved these changes
Jan 16, 2025
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, mhils The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Vincent056
pushed a commit
to Vincent056/security-profiles-operator
that referenced
this pull request
Jan 21, 2025
…startup This commit makes it so that the BPF program is loaded (and relocated) on profile recorder startup. When we then want to start the recording, we only need to attach the programs. This fixes the flakiness in kubernetes-sigs#2667 and kubernetes-sigs#2668 where program loading is taking so long that we miss container startup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds BPF instrumentation for
lsm/path_mknodWhich issue(s) this PR fixes:
None
Does this PR have test?
Yes.
Special notes for your reviewer:
Does this PR introduce a user-facing change?