[charts/occm] Implement imagePullSecret support for release 1.28

[carlotardl]

What this PR does / why we need it:
This PR implements imagePullSecrets for the openstack-cloud-controller-manager helm chart on release 1.28 branch.

Which issue this PR fixes(if applicable):
None applicable

Special notes for reviewers:

Release note:

NONE

[k8s-ci-robot]

Hi @carlotardl. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jichenjc]

/ok-to-test

[jichenjc]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jichenjc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wwentland]

Thank you!

This looks good to me, but the PR needs to be rebased against the release-1.28 branch. It would also be fantastic if you could bump the chart version again and squash the commits in here.

[wwentland]

This change looks good, but I am wondering if we should get it into master first before backporting it to release-1.28 ?

Specifically, I would have expected #2446 to look very similar to this set of changes, whereas it appears to implement vastly different ones.

[jichenjc]

good point, let's wait for master merge first

[wwentland]

In fact, we should probably close this and backport the cherry-pick of #2446 that lands in master.

[dulek]

Yup! @carlotardl, can you follow the basic backporting process? We expect the fixes to get into master first and then to the 1.28, 1.27 and 1.26 in that order. After master PR merges you need to comment with /cherry-pick release-1.28 to generate the first backport.

/hold

[carlotardl]

Hi, the changes for the master branch were merged. I was wondering since these are the same changes, that this PR could also be merged and keep the chart version. Thank you.

[wwentland]

Hi, the changes for the master branch were merged. I was wondering since these are the same changes, that this PR could also be merged and keep the chart version. Thank you.

Thank you for getting those into master! I am not entirely sure about backporting them though as they very much constitute a new feature. What is the best way to go about this, @dulek?

That being said, I'm sure that this feature would be very welcomed by users who have to use imagePullSecrets.

Once decided, we'd use prow's cherry-pick functionality to automatically create the backport:

• https://prow.k8s.io/command-help

[dulek]

@carlotardl, @wwentland: I think the rule is to always bump the chart version, so it's good this PR does so. I think I'm okay with backporting this, it's kind of a feature, but just configuration feature.

That being said this patch is different than what merged on master. Please follow the regular way and just do a cherry-pick from master.

[wwentland]

Yeah, the automatic backport failed as the chart version has to be bumped to a different version. It would probably be best to cherry pick 95a3823 from master and use a suitable chart version.

Could you be so kind, @carlotardl? I'm also happy to help if required.

[carlotardl]

I cherry-picked the commit 95a382323f6beb58953c9eac6864446ed36b2285 and bumped the version in 2 commits, if they need to be squashed let me know, thank you

[dulek]

I cherry-picked the commit 95a382323f6beb58953c9eac6864446ed36b2285 and bumped the version in 2 commits, if they need to be squashed let me know, thank you

Yup, let's squash it and we're good to go!

[carlotardl]

Hi, the commits were squashed, could you please take a look? Thank you

[wwentland]

Thank you!

/lgtm

[dulek]

/hold cancel