Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/support image transport argument to allow export images from and to docker daemon #2255

Merged
merged 3 commits into from
May 27, 2024

Conversation

will4j
Copy link
Contributor

@will4j will4j commented May 26, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Support export images to oci dir from local docker-daemon (default from remote registry).
Support push images from oci dir directly to docker-daemon, skip local registry.

usecase:

# export from docker-daemon
kk artifact export --skip-remove-artifact --image-transport docker-daemon -m manifests.yaml -o kubesphere.tar.gz
# push to docker-daemon
kk artifact images push --image-transport docker-daemon -f cluster.yaml -a kubesphere.tar.gz

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

Support export images from and push back to docker-daemon.

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 26, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@will4j will4j changed the title Feature/images transport feature/support image transport argument to allow export images from and to docker daemon May 26, 2024
@will4j
Copy link
Contributor Author

will4j commented May 26, 2024

/assign @pixiake

@pixiake
Copy link
Collaborator

pixiake commented May 27, 2024

@will4j Thanks for this contributions !
/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 6ee3a582caa21a30c17a96be76ed60035bcec0c2

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, will4j

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@ks-ci-bot ks-ci-bot merged commit 2cd49db into kubesphere:master May 27, 2024
7 checks passed
@will4j will4j deleted the feature/images-transport branch June 2, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants