Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support image start index when export images #2266

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

will4j
Copy link
Contributor

@will4j will4j commented Jun 1, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

when export image failed, like below(after add image Index to log):

[23]Source: docker.io/ubuntu:22.04
[23]Destination: my-registry/ubuntu:22.04 failed

you can use command kk artifact export --image-start-index 23 to retry image export from the failed image, no need to retry from start over.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

Support --image-start-index arg when export artifact

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. needs-rebase size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 1, 2024
Copy link

sonarqubecloud bot commented Jun 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.1% Duplication on New Code

See analysis details on SonarCloud

@will4j
Copy link
Contributor Author

will4j commented Jun 2, 2024

/assign @pixiake

@pixiake
Copy link
Collaborator

pixiake commented Jun 3, 2024

@will4j Thanks for this contributions !
/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 612d688bc7d977b964bdee69a36cef1a7ccc49b5

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, will4j

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2024
@ks-ci-bot ks-ci-bot merged commit 6beb293 into kubesphere:master Jun 3, 2024
5 checks passed
@will4j will4j deleted the feature/image-start-index branch June 4, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants