Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix document extractor node incorrectly processing doc and ppt files #12902

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AugNSo
Copy link

@AugNSo AugNSo commented Jan 21, 2025

Summary

Fixes #12889

  1. In the current code, document extractor node was using python-docx library to handle doc files, which it cannot process. this commit is trying to use unstructured API to handle doc files.
  2. In the current code, document extractor node is using partititon_ppt to handle ppt files, probably a leftover when unstructured[ppt] was still in pyproject.toml. This commit is trying to use unstructured API to handle ppt files.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 21, 2025
@crazywoola crazywoola requested a review from JohnJyong January 22, 2025 01:49
@crazywoola
Copy link
Member

Please fix the lint errors.

@AugNSo
Copy link
Author

AugNSo commented Jan 22, 2025

** Run Pytest / API Tests (3.12) (pull_request) ** Cancelled after 2m

Hi, I believe the error was not caused by linting but failure to pass test for _extract_text_from_doc function, the unit test is trying to call the function to process docx files, which should be calling _extract_text_from_docx instead with my new code.

I can try merge these two functions together under _extract_text_from_doc but I don't really think it is a good idea……

EDIT: updated the unit test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document extractor node incorrectly handles doc and ppt files
2 participants