Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: embedding demension change bug #12914

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

huangzhuo1949
Copy link
Contributor

@huangzhuo1949 huangzhuo1949 commented Jan 21, 2025

Summary

Close #12913

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 21, 2025
@JohnJyong
Copy link
Collaborator

Image
the logic is exist in the deal_dataset_vector_index_task.py, pls descripe the detail of how to replicate the issue @huangzhuo1949

@huangzhuo1949
Copy link
Contributor Author

Image the logic is exist in the deal_dataset_vector_index_task.py, pls descripe the detail of how to replicate the issue @huangzhuo1949

replicate step by step
1、upload some file to dataset
2、 change the embedding model of dataset while some file is indexing
3、worker1 has inited vector class by old embedding model because it has started indexing file
4、woker2 inited vector class by new embedding model
5、then the following phenomena occur: expected 1536 dimensions, not 1024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

embedding demension change bug
2 participants