Add Support for Algolia V4 - Breaking Change #862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el#845 (laravel#846) * feat(typesense): sync server state in getOrCreateCollectionFromModel This commit updates the `getOrCreateCollectionFromModel` method in `TypesenseEngine` to verify if a collection exists on the server. If not found, it is created. This ensures consistency between the worker and server states. * style: fix styleCI errors refactor: remove uneeded cast of flag The collectionExists flag was already cast as false, so recasting it serves no purpose * Update TypesenseEngine.php --------- Co-authored-by: Taylor Otwell <[email protected]>
* refactor(typesense): remove unused exists checks In laravel#820 we introduced an exists check method, which then lead to static state issues as described in laravel#845 Those where addressed in laravel#846 But now that the function always double-checks the existence, we can remove the exists check entirely and only rely on the Typesense server response for this state. This "fixes" issues where the server already has a collection and the client would try to recreate it. E.g. when it has flushed the index and another process or worker then creates the collection. * Update TypesenseEngine.php --------- Co-authored-by: Taylor Otwell <[email protected]>
NOTE: This is not backwards compatible with V3
….3"` 2. Tweak whitespace syntax
# Conflicts: # CHANGELOG.md # src/Scout.php # tests/Unit/AlgoliaEngineTest.php
Remove the test for php 8.0
|
Thanks @TheoGibbons. As you can see we have some merge conflicts here and some duplicate commits. I just merged 10.x into 11.x so could you please try to rebase anew from 11.x and resend the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Laravel Scout package to support Algolia V4. This update addresses the lack of compatibility with Algolia V4, as discussed in Issue #855.
Key Changes:
This guide helped with the upgrade: Algolia V4 Upgrade Guide.
Please review the following:
I've updated the Upgrade guide as requested by taylorotwell
I created a pull request onto the 10.X branch but driesvints requested it to be sent to the 11.x branch instead.