New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filtering `null` values in `where()` with Meilisearch #901

Merged

taylorotwell merged 1 commit into laravel:10.x from tobz-nz:patch-2

Jan 20, 2025

Contributor

tobz-nz commented Jan 20, 2025 •

edited

Loading

Currently filtering attributes by null value returns incorrect results.

TestModel::search('test')->where('parent_id', null)->count();
// 0

This is because the generated filter value is parent_id="". The correct value filtering for null is parent_id IS NULL and this PR fixes it.

A way to get around this bug is:

TestModel::search('test')->options(['filter' => 'parent_id IS NULL'])->count();
// x

But that's not very intuitive or convenient ;)


          Fix filtering null values in where() with Meilisearch

2cfe89c

taylorotwell merged commit 74be50b into laravel:10.x

19 checks passed

tobz-nz deleted the patch-2 branch

January 20, 2025 20:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet