Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

[#3] Address review findings of #24 #26

Merged

Conversation

elfenpiff
Copy link
Contributor

Notes for Reviewer

Addresses the review findings from: #24

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked
  4. Every source code file has the SPDX header SPDX-License-Identifier: $(LICENSE_CODE)
  5. Branch follows the naming format (elk-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elfenpiff elfenpiff requested a review from elBoberido October 31, 2023 08:25
@elfenpiff elfenpiff force-pushed the elk-2-address-review-findings branch from 7185c32 to 432647e Compare October 31, 2023 08:27
@elfenpiff elfenpiff changed the title [#2] Address review findings of #24 [#3] Address review findings of #24 Oct 31, 2023
@elfenpiff elfenpiff merged commit b7d6fa2 into larry-robotics:main Oct 31, 2023
2 of 3 checks passed
@elfenpiff elfenpiff deleted the elk-2-address-review-findings branch October 31, 2023 08:32
.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
README.md Show resolved Hide resolved
elfenpiff added a commit that referenced this pull request Nov 1, 2023
…from-pr-26

elk-#3 Fix review findings from PR #26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants