Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

elk-#8 Impl error trait for user facing errors #46

Conversation

elBoberido
Copy link
Collaborator

@elBoberido elBoberido commented Nov 7, 2023

Notes for Reviewer

This PR implements the Error trait for user facing errors.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked
  4. Every source code file has the SPDX header SPDX-License-Identifier: $(LICENSE_CODE)
  5. Branch follows the naming format (elk-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.

Relates to #3
Relates to #8

@elBoberido elBoberido requested a review from elfenpiff November 7, 2023 02:04
@elBoberido elBoberido self-assigned this Nov 7, 2023
Copy link
Contributor

@elfenpiff elfenpiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also adjust the example in the main readme.md. Here we still use .expect("..")

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@elfenpiff elfenpiff mentioned this pull request Nov 9, 2023
48 tasks
@elfenpiff elfenpiff merged commit 91a2703 into larry-robotics:main Nov 9, 2023
15 checks passed
@elBoberido elBoberido deleted the elk-impl-error-trait-for-user-facing-errors branch November 9, 2023 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants