fix(rpc): use SIP-30 format for stx_signTransaction
#6057
Merged
+94
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbwoolf
reviewed
Jan 15, 2025
fbwoolf
reviewed
Jan 15, 2025
|
Any issue to link from Linear? |
kyranjamie
force-pushed
the
refactor/stx-sign-transaction
branch
from
2f92a13 to
45805b0
Compare
kyranjamie
force-pushed
the
refactor/stx-sign-transaction
branch
from
45805b0 to
fe8a131
Compare
|
cc @fbwoolf for rereview. I've added a test for SIP30 compatibility |
fbwoolf
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding SIP-30 for
stx_signTransactionwhile maintaining backwards compatibility with existing API params.https://linear.app/leather-io/issue/LEA-1970/apply-new-stx-signtransaction-params-without-breaking-changes