Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: flakey test because exact values can change while test is running #6079

Merged
merged 1 commit into from
Jan 23, 2025
Merged

test: flakey test because exact values can change while test is running #6079

merged 1 commit into from
Jan 23, 2025

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Jan 23, 2025 •
edited by leather-bot
Loading

Try out Leather build 3d443d7 — Extension build, Test report, Storybook, Chromatic

Fixes issue with a recurring failing test that is too strict in that it checks for an exact value that may change.

@kyranjamie kyranjamie requested a review from fbwoolf January 23, 2025 11:48
@kyranjamie kyranjamie merged commit 5df2687 into dev Jan 23, 2025
34 checks passed
@kyranjamie kyranjamie deleted the test/fix-flaky-price-test branch January 23, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pete-watters pete-watters pete-watters approved these changes

@fbwoolf fbwoolf Awaiting requested review from fbwoolf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyranjamie @pete-watters