Cleanup tasks #40
Merged
Cleanup tasks #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing some general house keeping things, organizing imports, sorting CSS properties, etc.
Notes:
Was going to upgrade to Astro 4 but the
astro-iconpackage I'm using has a conflicting change with how I'm styling my icons. Doing the upgrade causes all the icons to automatically have their fill overridden to becurrentColorand there's currently no way to turn it off. This issue is a different problem but has the same cause and effect: natemoo-re/astro-icon#177So for now sticking to Astro v3. Potentially might change how I'm doing my icons if I want to upgrade sooner? But right now doesn't feel like it's important enough to change.