Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Tests cases for Chaoscenter Rest handler in Chaoscenter #4238

Merged
merged 11 commits into from
Dec 15, 2023
Merged

Feat: Tests cases for Chaoscenter Rest handler in Chaoscenter #4238

merged 11 commits into from
Dec 15, 2023

Conversation

Freedisch
Copy link
Contributor

@Freedisch Freedisch commented Oct 20, 2023 •
edited
Loading

Proposed changes

This PR add test cases for Chaoscenter authentication Rest handler

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

@namkyu1999 namkyu1999 added LFX-MENTORSHIP Linux Foundation Mentor ship Issue kind/unit-test labels Oct 21, 2023
@namkyu1999
Copy link
Member

Can you resolve conflicts?

@Freedisch
Copy link
Contributor Author

Can you resolve conflicts?

Done

@Freedisch
Copy link
Contributor Author

image

namkyu1999
namkyu1999 requested changes Nov 30, 2023
View reviewed changes
Copy link
Member

@namkyu1999 namkyu1999 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failed, Can you check @Freedisch ?
Screenshot 2023-11-30 at 9 16 45 PM

@Freedisch
Copy link
Contributor Author

@namkyu1999, I just fixed the falling tests

namkyu1999
namkyu1999 reviewed Dec 3, 2023
View reviewed changes
Copy link
Member

@namkyu1999 namkyu1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 @Freedisch, Can you add more test cases in each unit test? In most unit tests, there is only one test case. Checking code coverage will help you figure out which cases you need to add.

chaoscenter/authentication/api/handlers/rest/dex_auth_handler_test.go
"github.com/stretchr/testify/assert"
)

func TestDexLogin(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add positive case?

chaoscenter/authentication/api/handlers/rest/project_handler_test.go Outdated Show resolved Hide resolved
chaoscenter/authentication/api/handlers/rest/project_handler_test.go Outdated Show resolved Hide resolved
vanshBhatia-A4k9
vanshBhatia-A4k9 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@vanshBhatia-A4k9 vanshBhatia-A4k9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for inproving the test suite.
Also please address the review comments left by @namkyu1999

@Freedisch
Copy link
Contributor Author

Thank you for inproving the test suite. Also please address the review comments left by @namkyu1999

Sure I'm working on it

namkyu1999
namkyu1999 requested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@namkyu1999 namkyu1999 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check failed cases? I will approve this pr when you fix it 🚀 @Freedisch

Screenshot 2023-12-11 at 4 18 16 PM

@Freedisch
Copy link
Contributor Author

@namkyu1999, I just finished fixing the falling test and added a few ones

namkyu1999
namkyu1999 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@namkyu1999 namkyu1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@Saranya-jena Saranya-jena merged commit faa3627 into litmuschaos:master Dec 15, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namkyu1999 namkyu1999 namkyu1999 approved these changes

@amityt amityt amityt approved these changes

@vanshBhatia-A4k9 vanshBhatia-A4k9 vanshBhatia-A4k9 approved these changes

@Saranya-jena Saranya-jena Saranya-jena approved these changes

@SarthakJain26 SarthakJain26 Awaiting requested review from SarthakJain26

@Jonsy13 Jonsy13 Awaiting requested review from Jonsy13

Assignees

@Freedisch Freedisch

Labels
kind/unit-test LFX-MENTORSHIP Linux Foundation Mentor ship Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Freedisch @namkyu1999 @Saranya-jena @vanshBhatia-A4k9 @amityt