Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: Move the CUSTOM_TLS_CERT from subscriber config to subscriber secret #4254

Closed
wants to merge 14 commits into from

Conversation

RipulHandoo
Copy link
Contributor

@RipulHandoo RipulHandoo commented Nov 2, 2023

Proposed changes

It Move the CUSTOM_TLS_CERT from subscriber config to subscriber secret.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

@neelanjan00 neelanjan00 changed the title Fix bug: Move the CUSTOM_TLS_CERT from subscriber config to subscribe… Fix bug: Move the CUSTOM_TLS_CERT from subscriber config to subscriber secret Nov 2, 2023
…t sidebar (litmuschaos#4255)

* feat: Added stop experiment run feature in FE

Signed-off-by: Hrishav <[email protected]>

* chore: Updated manifest link

Signed-off-by: Hrishav <[email protected]>

* fix: Fixed add probe button shrinking issue

Signed-off-by: Hrishav <[email protected]>

* chore: removed propreitary message

Signed-off-by: Hrishav <[email protected]>

---------

Signed-off-by: Hrishav <[email protected]>
S-ayanide and others added 4 commits November 3, 2023 17:27
* chore: Updating GetProbesInExperimentRun API

* chore: Fixing goimport issue
@@ -21,6 +20,7 @@ metadata:
name: agent-secret
namespace: #{AGENT_NAMESPACE}
stringData:
CUSTOM_TLS_CERT: "#{CUSTOM_TLS_CERT}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to make changes in Chaoscenter directory, litmus-portal directory will be deprecated soon

@RipulHandoo RipulHandoo closed this Nov 6, 2023
@RipulHandoo RipulHandoo deleted the tls_cert branch November 6, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants