Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export ignore phpstan.neon.dist instead of phpstan.neon #57

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

mxr576
Copy link
Contributor

@mxr576 mxr576 commented Aug 16, 2024

This PR:

  • Fixes dist installation of the package
  • Provide ...
  • It breaks backward compatibility
  • Has unit tests (phpspec)
  • Has static analysis tests (psalm, phpstan)
  • Has documentation
  • Is an experimental thing

Follows #. Related to #. Fixes #.

@mxr576 mxr576 requested a review from drupol as a code owner August 16, 2024 07:00
Copy link

what-the-diff bot commented Aug 16, 2024

PR Summary

  • Update to .gitattributes File
    In an effort to enhance the development process, changes were made to the .gitattributes file. The system will no longer track changes to the /phpstan.neon file, which helps to reduce clutter in the project history. More importantly, the /phpstan.neon.dist file has been added for export. This allows the whole sequence of operations, rules, and configurations contained within the file to be reused in different environments or platforms seamlessly. This fosters reusability and consistency across the development process.

@mxr576
Copy link
Contributor Author

mxr576 commented Aug 16, 2024

image
Spotted on my local that there is an remnant phpstan.neon.dist in the downloaded dist version.

@drupol drupol merged commit 7bdab88 into loophp:main Aug 16, 2024
1 of 2 checks passed
@drupol
Copy link
Contributor

drupol commented Aug 16, 2024

Than you!
Will do the release very soon,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants