Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icon for .cmd #1117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add icon for .cmd #1117

wants to merge 1 commit into from

Conversation

spenserblack
Copy link

@spenserblack spenserblack commented Jan 15, 2025 •
edited
Loading

.cmd files are almost identical to .bat, with slightly different syntax and error handling.

TODO

  • Use cargo fmt
  • Add necessary tests
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

@spenserblack
Copy link
Author

spenserblack commented Jan 15, 2025 •
edited
Loading

Regarding the "TODO", I naively grepped for .bat and didn't find any tests or docs (just the one line in src/theme/icon.rs), so I'm assuming the other steps aren't necessary for this change.

@spenserblack spenserblack marked this pull request as ready for review January 15, 2025 17:33
@spenserblack spenserblack requested a review from zwpaper as a code owner January 15, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwpaper zwpaper Awaiting requested review from zwpaper zwpaper is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@spenserblack